Opened 5 years ago

Closed 5 years ago

#30440 closed Cleanup/optimization (fixed)

Temporary "required" attr is not removed if the browser doesn't supported ":valid" selector.

Reported by: Ben Muschol Owned by: Ben Muschol
Component: contrib.admin Version: dev
Severity: Normal Keywords: admin select selectfilter filteredselectfield
Cc: David Sanders Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The code in question: ​https://github.com/django/django/blob/stable/2.2.x/django/contrib/admin/static/admin/js/SelectFilter2.js#L175

If an error is thrown on line 181, the attribute is never removed. This leads to incorrect form validation when submitting.

I believe this would be fixed by moving the "field.removeAttr('required');" outside of the try/catch block

Steps to reproduce:

  1. Use a browser which does not support :valid pseudo-selector (I am using Chrome 73 on Mac)
  1. Open a page with the filtered multiple select field
  1. Submit the form without making any changes
  1. The browser will erroneously preform the "Missing required element" validation

Change History (3)

comment:1 by Mariusz Felisiak, 5 years ago

Cc: David Sanders added
Summary: "required" attribute is not removed if the browser doesn't supported ":valid" pseudo-selector in SelectFilter2.js → Temporary "required" attr is not removed if the browser doesn't supported ":valid" selector.
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization
Version: 2.2 → master

Agreed, we can add this small cleanup, you check ​comment from the author of original patch.

comment:2 by Ben Muschol, 5 years ago

Has patch: set
Owner: changed from nobody to Ben Muschol
Status: new → assigned

Sounds good, I've added a patch here: ​https://github.com/django/django/pull/11331

Let me know if I'm doing something wrong in terms of github style/ticket management

comment:3 by Mariusz Felisiak, 5 years ago

Resolution: → fixed
Status: assigned → closed

Fixed in 8eb413371462eb5d2ea2a5b305f5954ee112c527.

Note: See TracTickets for help on using tickets.
Back to Top