Opened 4 years ago

Closed 20 months ago

#30360 closed New feature (fixed)

Support rotation of secret keys.

Reported by: Andreas Pelme Owned by: tim-schilling
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: Ryan Hiebert Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Andreas Pelme)

Having the possibility to rotate the secret key would be nice.

See ​the discussion in django-developers for a longer explanation and discussion.

Change History (11)

comment:1 Changed 4 years ago by Andreas Pelme

I have started working on this and will work on it during the Djangocon 2019 sprints tomorrow.

comment:2 Changed 4 years ago by Andreas Pelme

Has patch: set
Needs documentation: set
Needs tests: set
Patch needs improvement: set

comment:3 Changed 4 years ago by Andreas Pelme

Description: modified (diff)
Summary: Pluggable secret key backend → Support rotation of secret keys

comment:4 Changed 4 years ago by Mariusz Felisiak

Summary: Support rotation of secret keys → Support rotation of secret keys.
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → New feature
Version: 2.2 → master

​PR

comment:5 Changed 4 years ago by Ryan Hiebert

Cc: Ryan Hiebert added

comment:6 Changed 20 months ago by Carlton Gibson

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:7 Changed 20 months ago by Carlton Gibson

Owner: changed from Andreas Pelme to tim-schilling

​New PR adding SECRET_KEY_FALLBACKS based on discussion/reviews of previous approaches.

comment:8 Changed 20 months ago by Mariusz Felisiak

Needs documentation: set
Needs tests: set
Patch needs improvement: set

comment:9 Changed 20 months ago by Mariusz Felisiak

Needs tests: unset
Patch needs improvement: unset

comment:10 Changed 20 months ago by Mariusz Felisiak

Needs documentation: unset
Triage Stage: Accepted → Ready for checkin

comment:11 Changed 20 months ago by Mariusz Felisiak <felisiak.mariusz@…>

Resolution: → fixed
Status: assigned → closed

In 0dcd549b:

Fixed #30360 -- Added support for secret key rotation.

Thanks Florian Apolloner for the implementation idea.

Co-authored-by: Andreas Pelme <andreas@…>
Co-authored-by: Carlton Gibson <carlton.gibson@…>
Co-authored-by: Vuyisile Ndlovu <terrameijar@…>

Note: See TracTickets for help on using tickets.
Back to Top