Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#30347 closed Cleanup/optimization (fixed)

A typo in Aggregation document.

Reported by: PM Owned by: Daniel Musketa
Component: Documentation Version: 2.2
Severity: Normal Keywords:
Cc: ming.p.peng@… Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In the online document, Using Django -> Models and databases -> Aggregation page,
section Filtering on annotations, ​https://docs.djangoproject.com/en/2.2/topics/db/aggregation/#filtering-on-annotations

The original text is

>>> highly_rated = Count('books', filter=Q(books__rating__gte=7))
>>> Author.objects.annotate(num_books=Count('books'), highly_rated_books=highly_rated)

Here, should 'books' be 'book' in these two lines?

Change History (6)

comment:1 by Mariusz Felisiak, 6 years ago

Easy pickings: set
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization

Thanks for the report. Yes, there is a typo books -> book.

Last edited 6 years ago by Mariusz Felisiak (previous) (diff)

comment:2 by Phillip Ahereza, 6 years ago

Owner: changed from nobody to Phillip Ahereza
Status: new → assigned

comment:3 by Daniel Musketa, 6 years ago

Owner: changed from Phillip Ahereza to Daniel Musketa

​https://github.com/django/django/pull/11204

comment:4 by Mariusz Felisiak, 6 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 6 years ago

Resolution: → fixed
Status: assigned → closed

In ba726067:

Fixed #30347 -- Fixed typo in docs/topics/db/aggregation.txt.

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 6 years ago

In f5c1d02f:

[2.2.x] Fixed #30347 -- Fixed typo in docs/topics/db/aggregation.txt.

Backport of ba726067604ce5a8ca3919edf653496722b433ab from master

Note: See TracTickets for help on using tickets.
Back to Top