Opened 5 years ago

Closed 5 years ago

#30338 closed Bug (invalid)

sitemap.xml template should not use localization

Reported by: Christian Peters Owned by: nobody
Component: contrib.sitemaps Version: 2.2
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Christian Peters)

The sitemap.xml receives a priority as float. This float should never be localized, even if localization is generally turned on. This is because some localizations would change e.g. 0.8 to 0,8, rendering the format as invalid.

​https://github.com/django/django/blob/master/django/contrib/sitemaps/templates/sitemap.xml#L9

Pull Request: ​https://github.com/django/django/pull/11183

Change History (6)

comment:2 by Christian Peters, 5 years ago

Description: modified (diff)

comment:3 by Christian Peters, 5 years ago

Description: modified (diff)

comment:4 by Carlton Gibson, 5 years ago

Needs tests: set
Triage Stage: Unreviewed → Accepted

Yep. OK. Thank you.

For reference: ​https://www.sitemaps.org/protocol.html

comment:5 by Christian Peters, 5 years ago

Sorry, this is not a real bug. I found out that I'm overwriting get_urls() and this is performing said check already.

comment:6 by Carlton Gibson, 5 years ago

Resolution: → invalid
Status: new → closed

OK. Thanks for the follow-up.

Note: See TracTickets for help on using tickets.
Back to Top