Opened 6 years ago
Closed 6 years ago
#30301 closed Cleanup/optimization (fixed)
`django.core.management.base.OutputWrapper` discards the `style_func` argument.
| Reported by: | Adam Barnes | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | 2.1 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
I would have assumed that line should read self.style_func = style_func. If it's correct to be discarding the provided style_func arg, and setting the attribute on self to be None, the argument shouldn't be provided.
Of course, I'm not particularly familiar with this inner working of Django yet, so it's possible this is entirely intentional for some reason I don't yet know, in which case, a comment explaining the discarding wouldn't go amiss.
Change History (3)
comment:1 by , 6 years ago
| Has patch: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Cleanup/optimization |
comment:2 by , 6 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note:
See TracTickets
for help on using tickets.
PR