Opened 9 months ago

Closed 9 months ago

#30250 closed Bug (duplicate)

Due to iOS Safari 12 issue, SameSite flag on session and CSRF cookies should NOT be Lax by default

Reported by: Flávio Juvenal Owned by: nobody
Component: Core (Other) Version: 2.1
Severity: Normal Keywords: samesite, csrf, session, cookies
Cc: Maciej Olko Triage Stage: Someday/Maybe
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Flávio Juvenal)

There's a iOS Safari 12 issue that prevents common flows (sequences of requests) to work properly if there's SameSite=lax on cookies. This issue was confirmed by Daniel Bates, from Apple and it's still open.

Examples of broken flows:

Since Safari 12 is the current stable version and it's widely deployed on iOS devices, I believe the Django default for CSRF_COOKIE_SAMESITE and SESSION_COOKIE_SAMESITE should be None, not Lax. That's the most general solution and it's the one recommended by Microsoft to fix the similar issue on ASP.NET (they didn't change the default, though).

Core developers, could you please let me know if you agree with that change, so I can make a PR updating the defaults and the documentation?

I think both CSRF and Session cookies shouldn't have the SameSite flag because I've found many 403 Forbidden issues on both on Safari 12. If more steps to reproduce beyond the links above are necessary, please let me know.

---
Update:

In fact, a much simpler flow is broken on Safari 12 with the default "Lax" settings.
If the user comes from a cross-site redirection (like a tracker link from an email provider), Safari doesn't send samesite=lax cookies on the request. This causes multiple issues:

  1. User will not be logged in if SESSION_COOKIE_SAMESITE = 'Lax'. That behavior is only expected if 'Strict'.
  2. User will not be able to make AJAX POST requests if CSRF_COOKIE_SAMESITE = 'Lax', because JS code won't be able to read the CSRF cookie.
  3. POSTs on other open tabs/windows will fail if CSRF_COOKIE_SAMESITE = 'Lax', because Safari triggered a CSRF cookie update after the first request without cookies.

Those issues do not happen on Chrome.
Full example here: https://github.com/vintasoftware/safari-samesite-cookie-issue

Change History (9)

comment:1 Changed 9 months ago by Flávio Juvenal

Description: modified (diff)

comment:2 Changed 9 months ago by Flávio Juvenal

Description: modified (diff)

comment:3 Changed 9 months ago by Flávio Juvenal

Description: modified (diff)

comment:4 Changed 9 months ago by Flávio Juvenal

Description: modified (diff)

comment:5 Changed 9 months ago by Tim Graham

Component: UncategorizedCore (Other)
Easy pickings: unset
Triage Stage: UnreviewedSomeday/Maybe

Please raise the issue on the DevelopersMailingList as it gets more attention than this ticket tracker.

comment:6 Changed 9 months ago by Flávio Juvenal

Description: modified (diff)

comment:7 Changed 9 months ago by Flávio Juvenal

comment:8 Changed 9 months ago by Maciej Olko

Cc: Maciej Olko added

comment:9 Changed 9 months ago by Tim Graham

Resolution: duplicate
Status: newclosed

Duplicate of #29975.

Note: See TracTickets for help on using tickets.
Back to Top