Disallow non-uppercase settings in settings.configure()

[orlnub123]

Contradictory to the documentation, settings.configure() and UserSettingsHolder.__getattr__() allow non-upper settings to be set and retrieved, respectively. This allows for the following to happen:

import types
from django.conf import settings

settings.configure(types.SimpleNamespace(foo="bar"), baz="qux")
print(settings.foo, settings.baz)  # Doesn't error

[Parth Patil]

I was able to reproduce this.
So are you suggesting to remove the support, to add and retrieve new settings?
I think this might be used as a feature by some people.

[orlnub123]

So are you suggesting to remove the support, to add and retrieve new settings?

Just non-upper ones. Some components such as diffsettings or the debug view rely on there only being uppercase settings.

I think this might be used as a feature by some people.

I agree that someone might be using them but since it contradicts the documentation a deprecation period shouldn't be necessary.

[Tim Graham <timograham@…>]

In 163236e:

Fixed #30234 -- Disallowed non-upper settings in settings.configure().

[k4ml]

The docs still showing example that using _ in settings.py - ​https://github.com/django/django/blob/7f33c1e22dbc34a7afae7967783725b10f1f13b1/docs/ref/settings.txt#L1951

And this check cause issue when third party app is calling settings.configure():-

​https://github.com/idlesign/pytest-djangoapp/blob/master/pytest_djangoapp/plugin.py#L42

If this is no longer recommended practice, the docs above should be fixed not to use _ anymore in settings.py.

[Mariusz Felisiak]

Replying to k4ml:

The docs still showing example that using _ in settings.py - ​https://github.com/django/django/blob/7f33c1e22dbc34a7afae7967783725b10f1f13b1/docs/ref/settings.txt#L1951

And this check cause issue when third party app is calling settings.configure():-

​https://github.com/idlesign/pytest-djangoapp/blob/master/pytest_djangoapp/plugin.py#L42

If this is no longer recommended practice, the docs above should be fixed not to use _ anymore in settings.py.

This ticket has nothing to do with using _ in settings.py, it's about non-uppercase setting names.

[k4ml]

Replying to Mariusz Felisiak:

This ticket has nothing to do with using _ in settings.py, it's about non-uppercase setting names.

_ failed isupper() check.

Btw the fix is simple actually, add:-

del _

at the end of settings.py. The localization docs should add this in notes.

[Mariusz Felisiak]

Replying to k4ml:

Btw the fix is simple actually, add:-

del _

at the end of settings.py. The localization docs should add this in notes.

It's not an issue in Django or its docs. It's an issue in pytest_djangoapp. _ is not a setting name and should not be passed to the .configure().