Opened 3 years ago

Closed 3 years ago

#30196 closed Cleanup/optimization (fixed)

Make FileResponse always set Content-Disposition header.

Reported by: Piotr Kunicki Owned by: Piotr Kunicki
Component: HTTP handling Version: dev
Severity: Normal Keywords: FileResponse file response Content-Disposition header attachment inline
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Piotr Kunicki)

FileResponse currently sets the Content-Disposition header only if as_attachment is true.

Setting it explicitly to, e.g. 'inline; filename="example.png"' in the other case would allow the browser to set a default name for that inline file in case a user attempts to download it with the 'Save image as...' option.

That filename value is also visible in the title of the tab when image is being viewed directly in Firefox (at least v56).

Created a pull request:

Change History (9)

comment:1 Changed 3 years ago by Piotr Kunicki

Description: modified (diff)

comment:2 Changed 3 years ago by Simon Charette

Needs tests: set
Triage Stage: UnreviewedAccepted

The feature request makes sense but it's still missing tests.

comment:3 Changed 3 years ago by Piotr Kunicki

Sorry for beginner questions, but: as in, you want me to add some unit tests?
No problem, but wouldn't a single test be enough?
All this change does, after all, is setting Content-Disposition when as_attachment=False, so checking if it works shouldn't require more.

I also noticed there's no unit test checking if setting a custom filename works, so i added it to the same one test.

What else to add?

comment:4 Changed 3 years ago by Piotr Kunicki

Needs tests: unset

comment:5 Changed 3 years ago by Tim Graham

Easy pickings: unset
Needs documentation: set

comment:6 Changed 3 years ago by Piotr Kunicki

Needs documentation: unset

Added documentation changes to the commit in PR.

comment:7 Changed 3 years ago by Tobias Kunze

Triage Stage: AcceptedReady for checkin

comment:8 Changed 3 years ago by Tobias Kunze

Owner: changed from nobody to Piotr Kunicki
Status: newassigned

comment:9 Changed 3 years ago by Carlton Gibson <carlton.gibson@…>

Resolution: fixed
Status: assignedclosed

In de4832c:

Fixed #30196 -- Made FileResponse set Content-Disposition inline if filename is available.

Note: See TracTickets for help on using tickets.
Back to Top