Changes between Initial Version and Version 1 of Ticket #30189


Ignore:
Timestamp:
02/16/2019 10:52:37 AM (19 months ago)
Author:
Simon Charette
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30189 – Description

    initial v1  
    11The migration executor only adds the outer `BEGIN`/`COMMIT` [https://github.com/django/django/blob/edec11ce86a1a0d9e4c5a2a0df6acaf655041c24/django/db/migrations/executor.py#L243-L247 if the migration is atomic] and [https://github.com/django/django/blob/edec11ce86a1a0d9e4c5a2a0df6acaf655041c24/django/db/backends/base/schema.py#L97 the schema editor can rollback DDL] but the current `sqlmigrate` logic only takes `migration.atomic` into consideration.
    22
    3 The issue change be addressed by
     3The issue can be addressed by
    44
    551. Changing `sqlmigrate` [https://github.com/django/django/blob/edec11ce86a1a0d9e4c5a2a0df6acaf655041c24/django/core/management/commands/sqlmigrate.py#L59 assignment] of `self.output_transaction` to consider `connection.features.can_rollback_ddl` as well.
Back to Top