sqlmigrate wraps it's outpout in BEGIN/COMMIT even if the database doesn't support transactional DDL

[Simon Charette]

The migration executor only adds the outer BEGIN/COMMIT ​if the migration is atomic and ​the schema editor can rollback DDL but the current sqlmigrate logic only takes migration.atomic into consideration.

The issue can be addressed by

1. Changing sqlmigrate ​assignment of self.output_transaction to consider connection.features.can_rollback_ddl as well.
2. Adding a test in tests/migrations/test_commands.py based on ​an existing test for non-atomic migrations that mocks connection.features.can_rollback_ddl to False instead of overdidding MIGRATION_MODULES to point to a non-atomic migration.

I marked the ticket as easy picking because I included the above guidelines but feel free to uncheck it if you deem it inappropriate.

[Carlton Gibson]

I marked the ticket as easy picking because I included the above guidelines but feel free to uncheck it if you deem it inappropriate.

Super. We don't have enough Easy Pickings tickets for the demand, so this kind of thing is great. (IMO 🙂)

[Parth Patil]

Hey, I'm working on this ticket, I would like you to know as this is my first ticket it may take little longer to complete :).
Here is a ​| link to the working branch

You may feel free to post references or elaborate more on the topic.

[Carlton Gibson]

Hi Parth. No problem. If you need help please reach out to e.g. ​django-core-mentorship citing this issue, and where you've got to/got stuck.

Welcome aboard, and have fun! ✨

[Parth Patil]

here is a link to the patch

​https://github.com/django/django/pull/11039

[Tim Graham <timograham@…>]

In acc04198:

Fixed #30189 -- Removed transaction from sqlmigrate output if database doesn't use one.