#30175 closed Bug (fixed)

Django 2.1.6, 2.0.11, and 1.11.19 were mispackaged with missing or extra files

Reported by: rm_ Owned by: Carlton Gibson
Component: Core (Other) Version: 1.11
Severity: Release blocker Keywords:
Cc: Patrick Cloke Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by rm_)

It looks like the distributed django 1.11.19 release does not match the code in 1.11.19 tag.

Got this while running my test suite:

  File "/usr/local/lib/python2.7/site-packages/django/template/base.py", line 184, in __init__
    engine = Engine.get_default()
  File "/usr/local/lib/python2.7/site-packages/django/utils/lru_cache.py", line 124, in wrapper
    result = user_function(*args, **kwds)
  File "/usr/local/lib/python2.7/site-packages/django/template/engine.py", line 76, in get_default
    django_engines = [engine for engine in engines.all()
  File "/usr/local/lib/python2.7/site-packages/django/template/utils.py", line 89, in all
    return [self[alias] for alias in self]
  File "/usr/local/lib/python2.7/site-packages/django/template/utils.py", line 80, in __getitem__
    engine = engine_cls(params)
  File "/usr/local/lib/python2.7/site-packages/django/template/backends/django.py", line 30, in __init__
    options['libraries'] = self.get_templatetag_libraries(libraries)
  File "/usr/local/lib/python2.7/site-packages/django/template/backends/django.py", line 48, in get_templatetag_libraries
    libraries = get_installed_libraries()
  File "/usr/local/lib/python2.7/site-packages/django/template/backends/django.py", line 113, in get_installed_libraries
    for name in get_package_libraries(pkg):
  File "/usr/local/lib/python2.7/site-packages/django/template/backends/django.py", line 130, in get_package_libraries
    "trying to load '%s': %s" % (entry[1], e)
InvalidTemplateLibrary: Invalid template library specified. ImportError raised when trying to load 'django.contrib.admin.templatetags.base': cannot import name getfullargspec 

But 1.11.19 tag on github does not have that file:

~/src/django/django/contrib/admin/templatetags$ ls -ltrh *py
-rw-r--r-- 1 rm rm    0 dic  7  2015 __init__.py
-rw-r--r-- 1 rm rm 2,1K feb 11 12:57 log.py
-rw-r--r-- 1 rm rm 1,8K feb 11 12:57 admin_urls.py
-rw-r--r-- 1 rm rm  304 feb 11 12:57 admin_static.py
-rw-r--r-- 1 rm rm 3,0K feb 11 12:57 admin_modify.py
-rw-r--r-- 1 rm rm  18K feb 11 12:57 admin_list.py

Downloading and unzipping:
https://files.pythonhosted.org/packages/6b/2a/6625366e0e26fcc638c76d1a8b63d8d24a99d129cfebf8b101aaab0327fd/Django-1.11.19-py2.py3-none-any.whl

There's a django.contrib.admin.templatetags.base that is not in git:

$ django/contrib/admin/templatetags$ ls -ltrh *py
-rw-r--r-- 1 rm rm    0 gen  1  2014 __init__.py
-rw-r--r-- 1 rm rm 1,3K feb 11 10:17 base.py
-rw-r--r-- 1 rm rm  304 feb 11 10:28 admin_static.py
-rw-r--r-- 1 rm rm 2,1K feb 11 10:30 log.py
-rw-r--r-- 1 rm rm 1,8K feb 11 10:30 admin_urls.py
-rw-r--r-- 1 rm rm 3,0K feb 11 10:30 admin_modify.py
-rw-r--r-- 1 rm rm  18K feb 11 10:30 admin_list.py

Change History (15)

comment:1 Changed 22 months ago by rm_

Description: modified (diff)

comment:2 Changed 22 months ago by rm_

Description: modified (diff)

comment:3 Changed 22 months ago by Tim Graham

Component: UncategorizedCore (Other)
Triage Stage: UnreviewedAccepted
Type: UncategorizedBug

It appears there was an error in packaging the release.

comment:4 Changed 22 months ago by Carlton Gibson

Yes. I can't currently account for the issue. Commits and tags look OK, as does repository status when checking out those tags. I will verify and re-issue where needed.

comment:5 Changed 22 months ago by Patrick Cloke

Cc: Patrick Cloke added

comment:6 Changed 22 months ago by Tim Graham

Summary: Broken django 1.11.19 release for python2.7Django 2.1.6, 2.0.11, and 1.11.19 were mispackaged with missing or extra files

comment:7 Changed 22 months ago by Giovanni Totaro - aka Vanni

Probably related anomaly --> After updating Django from 2.1.5 to 2.1.6 via pip3 I get:

./manage.py makemigrations
Migrations for 'auth':
  /home/---/venvs/---/lib/python3.5/site-packages/django/contrib/auth/migrations/0012_auto_20190211_1508.py
    - Alter field name on group
cat /home/---/venvs/---/lib/python3.5/site-packages/django/contrib/auth/migrations/0012_auto_20190211_1520.py 
# Generated by Django 2.1.6 on 2019-02-11 14:20

from django.db import migrations, models


class Migration(migrations.Migration):

    dependencies = [
        ('auth', '0011_update_proxy_permissions'),
    ]

    operations = [
        migrations.AlterField(
            model_name='group',
            name='name',
            field=models.CharField(max_length=80, unique=True, verbose_name='name'),
        ),
    ]

but commit Fixed #29939 -- Increased Group.name max_length to 150 characters has 2.2.x tags, and pip version has max_length=80 in django/contrib/auth/models.py:111

comment:8 Changed 22 months ago by Carlton Gibson

Hi Giovanni. Yes. Hold off for now. New releases coming.

comment:9 Changed 22 months ago by Carlton Gibson

Owner: changed from nobody to Carlton Gibson
Status: newassigned

comment:10 Changed 22 months ago by GitHub <noreply@…>

In b39bd0aa:

Refs #30175 -- Added release notes for 2.1.7, 2.0.12, and 1.11.20 releases.

comment:11 Changed 22 months ago by Carlton Gibson <carlton.gibson@…>

In 1672ed5c:

[2.2.x] Refs #30175 -- Added release notes for 2.1.7, 2.0.12, and 1.11.20 releases.

Backport of b39bd0aa6d5667d6bbcf7d349a1035c676e3f972 from master

comment:12 Changed 22 months ago by Carlton Gibson <carlton.gibson@…>

In 168bfdd:

[2.1.x] Refs #30175 -- Added release notes for 2.1.7, 2.0.12, and 1.11.20 releases.

Backport of b39bd0aa6d5667d6bbcf7d349a1035c676e3f972 from master

comment:13 Changed 22 months ago by Carlton Gibson <carlton.gibson@…>

In 11485a3:

[2.0.x] Refs #30175 -- Added release notes for 2.0.12, and 1.11.20 releases.

Backport of b39bd0aa6d5667d6bbcf7d349a1035c676e3f972 from master

comment:14 Changed 22 months ago by Carlton Gibson <carlton.gibson@…>

In f2c5f66c:

[1.11.x] Refs #30175 -- Added release notes for 1.11.20 release.

Backport of b39bd0aa6d5667d6bbcf7d349a1035c676e3f972 from master

comment:15 Changed 22 months ago by Carlton Gibson

Resolution: fixed
Status: assignedclosed

OK, so this should be fixed. New releases are up. Packages look correct. Running the test suite against the src-dist release reveals no issues.

Sorry for the inconvenience.

Note: See TracTickets for help on using tickets.
Back to Top