Opened 5 years ago

Closed 5 years ago

#30173 closed Cleanup/optimization (fixed)

Use subprocess.run and PGPASSWORD for client in postgres backend

Reported by: Daniel Bowring Owned by: nobody
Component: Database layer (models, ORM) Version: 2.1
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

​subprocess.run was added in python 3.5 (which is the minimum version since Django 2.1). This function allows you to pass a custom environment for the subprocess.

Using this in django.db.backends.postgres.client to set PGPASSWORD simplifies the code and makes it more reliable.

Change History (5)

comment:1 by Daniel Bowring, 5 years ago

Has patch: set

comment:2 by Daniel Bowring, 5 years ago

​Github PR

comment:3 by Tim Graham, 5 years ago

Component: Uncategorized → Database layer (models, ORM)
Easy pickings: unset
Patch needs improvement: set
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization

Some test failures need to be addressed.

comment:4 by Daniel Bowring, 5 years ago

I've updated the PR to fix the tests.

comment:5 by Tim Graham <timograham@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In cf826c9a:

Fixed #30173 -- Simplified db.backends.postgresql.client.

Note: See TracTickets for help on using tickets.
Back to Top