[patch] Small change to django.contrib.admin.urls to allow permalink() usage

[Collin Grady <cgrady@…>]

The current urls.py for the admin app doesn't name some of the params, so trying to use permalink() with it fails - as this is useful in some situations, and doesn't harm the function of the existing app at all, I think it should be updated so it does work with it.

[Collin Grady <cgrady@…>]

Afterthought, as an example you can do something like this with this change applied:

    def get_admin_url(self):
        return ('django.contrib.admin.views.main.change_stage', None, {'app_label': 'blog', 'model_name': 'entry', 'object_id': self.id})
    get_admin_url = permalink(get_admin_url)

It might be possible to grab that info through _meta or such also, but I haven't played with that much :)

[Collin Grady <cgrady@…>]

Hmm, might be possible to make this a generalized and always-there function on models?

    def get_admin_url(self):
        return ('django.contrib.admin.views.main.change_stage', None, {'app_label': self._meta.app_label, 'model_name': self._meta.module_name, 'object_id': self.__getattribute__(self._meta.pk.attname)})

That seems to pick up app/model/id values instantly - or would it need a check to see if there even is a pk?

[Collin Grady <cgrady@…>]

Didn't realize this before, but the last entry in the dict could be changed to

'object_id': getattr(self, self._meta.pk.attname)

[Collin Grady <cgrady@…>]

What do I need to improve in the patch? :)

[Chris Beaven]

Permalink doesn't fail, you just need to pass the arguments positionally at the moment:

    @models.permalink
    def get_admin_url(self):
        return 'django.contrib.admin.views.main.change_stage', [
            self._meta.app_label, self._meta.module_name,
            getattr(self, self._meta.pk.attname)
        ]

(and changing it probably isn't worth it with newforms-admin on the way)