Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#30117 closed Cleanup/optimization (fixed)

Fix test with mysqlclient 1.4.0+

Reported by: Mariusz Felisiak Owned by: Mariusz Felisiak
Component: Database layer (models, ORM) Version: 2.2
Severity: Normal Keywords: mysql mysqclient
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Three tests are failing with mysqlclient==1.4.0 (see ​release notes):

  • backends.mysql.test_schema.SchemaEditorTests.test_quote_value (value=False),
  • backends.tests.BackendTestCase.test_cursor_execute_with_pyformat,
  • raw_query.tests.RawQueryTests.test_pyformat_params

on both MySQL and MariaDB.

Change History (9)

comment:1 by Mariusz Felisiak, 5 years ago

I created issue in the mysqlclient due to the crash of cursor.execute() when passing mapping as args (see ​mysqlclient-python-323).

comment:2 by Carlton Gibson, 5 years ago

Do we need to pin to 1.3.14 in the meantime?

comment:3 by Mariusz Felisiak, 5 years ago

Has patch: set

​PR

I don't think so. mysqlclient==1.4.1 is already released.

comment:4 by Mariusz Felisiak, 5 years ago

Triage Stage: Unreviewed → Accepted

comment:5 by Mariusz Felisiak, 5 years ago

Summary: Add support for mysqlclient 1.4.0 → Fix test with mysqlclient 1.4.0

comment:6 by Mariusz Felisiak, 5 years ago

Summary: Fix test with mysqlclient 1.4.0 → Fix test with mysqlclient 1.4.0+

comment:7 by GitHub <noreply@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In f05c02c:

Fixed #30117 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.4.0+.

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In 70aeb6ab:

[2.2.x] Fixed #30117 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.4.0+.

Backport of f05c02c4b8d4e423e57d453c4bd699dc5ff7eaa7 from master

comment:9 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In 03219b5f:

[2.1.x] Fixed #30117 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.4.0+.

Backport of f05c02c4b8d4e423e57d453c4bd699dc5ff7eaa7 from master

Note: See TracTickets for help on using tickets.
Back to Top