diffsettings leaves out custom default settings
If you've manually configured the settings with default settings that differ from the default they won't show up if you run the diffsettings command. This is only observable on master as before 49b6793 the settings were forcefully setup, replacing the manually configured settings.
The reason this happens is because module_to_dict
reads the settings from the __dict__
. If you haven't manually configured your settings this is fine because the default wrapped settings object preassigns all settings to the __dict__
. Since UserSettingsHolder
, the class that wraps manually configured settings, relies on the __dir__
+ __getattr__
pattern which allows the underlying default settings object to be dynamic it doesn't store settings from the default settings in its __dict__
.
Change History
(6)
Triage Stage: |
Unreviewed → Accepted
|
Cc: |
Hasan Ramezani added
|
Severity: |
Normal → Release blocker
|
Resolution: |
→ fixed
|
Status: |
new → closed
|
Resolution: |
fixed
|
Status: |
closed → new
|
Resolution: |
→ fixed
|
Status: |
new → closed
|
Marking as
master
release blocker since it's a regression introduced by 49b679371fe9beddcd23a93b5fdbadea914f37f8 (#29236).