Opened 7 years ago
Closed 7 years ago
#30009 closed Bug (duplicate)
Invalid SQL query when using Subquery, caused by table alias quoting.
| Reported by: | Davit Mikava | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | 1.11 |
| Severity: | Normal | Keywords: | queryset subquery |
| Cc: | Mariusz Felisiak | Triage Stage: | Accepted |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
It seems that table aliases quoting issue reported in #27862 ticket still exists.
This happens when Django is configured with PostgreSQL backend.
to reproducing it use following models:
class Case(models.Model):
case_number = models.CharField(max_length=32)
parent_case = models.ForeignKey('self', null=True, blank=True)
class Subject(models.Model):
name = models.CharField(max_length=128)
case = models.ForeignKey(Case)
class Task(models.Model):
num = models.CharField(max_length=32, blank=True)
case = models.ForeignKey(Case, null=True, blank=True)
and then:
Task.objects.annotate(
top_case_id=Coalesce(F('case__parent_case__parent_case_id'), F('case__parent_case_id'), F('case_id')),
subject=Subquery(Subject.objects.filter(case_id=OuterRef('top_case_id')))
).all()
Following SQL is generated:
SELECT
"test_app_task"."id",
"test_app_task"."num",
"test_app_task"."case_id",
COALESCE(T3."parent_case_id", "test_app_case"."parent_case_id", "test_app_task"."case_id") AS "top_case_id",
(SELECT
U0."id",
U0."name",
U0."case_id"
FROM "test_app_subject" U0
WHERE U0."case_id" = (COALESCE("T3"."parent_case_id", "test_app_case"."parent_case_id", "test_app_task"."case_id"))) AS "subject"
FROM "test_app_task" LEFT OUTER JOIN
"test_app_case" ON ("test_app_task"."case_id" = "test_app_case"."id") LEFT OUTER JOIN
"test_app_case" T3 ON ("test_app_case"."parent_case_id" = T3."id")
Error:
ProgrammingError: missing FROM-clause entry for table "T3"
LINE 1: ...st_app_subject" U0 WHERE U0."case_id" = (COALESCE("T3"."pare...
SQL works as expected, when quotes are removed from T3 alias.
Change History (5)
comment:1 by , 7 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 7 years ago
| Cc: | added |
|---|
comment:4 by , 7 years ago
I think you are right Felix, both use a subquery with an outer ref to an annotate field.
I'll close this one as a duplicate of #29214 and reword its summary.
comment:5 by , 7 years ago
| Resolution: | → duplicate |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Reproduced against latest
stable/1.11.xandmasterat 196b420fcb0cbdd82970e2b9aea80251bde82056.