Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#29959 closed Bug (fixed)

Random LooseVersion errors while getting multiple wkb values

Reported by: Claude Paroz Owned by: nobody
Component: GIS Version: 2.1
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

From [f185d929fa1c0caa], each call to geometry wkb value (used in the json representation) will call GEOSversion() to test a corner case condition.
Unfortunately and randomly, this causes 'LooseVersion' object has no attribute 'version' errors. It might be memory related because the same operation sometimes fails, sometimes succeeds in the exact same code conditions.

It's hard to know what part of the code to blame, but I would argue that calling a GEOS method for each wkb value retrieval is suboptimal, as the GEOS version should not change between server restart. We may find a way to cache the GEOS version between calls.

Change History (6)

comment:1 Changed 9 months ago by Tim Graham

Triage Stage: UnreviewedAccepted

comment:2 Changed 9 months ago by Claude Paroz

Has patch: set
Last edited 9 months ago by Tim Graham (previous) (diff)

comment:3 Changed 9 months ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In e7e55059:

Fixed #29959 -- Cached GEOS version in WKBWriter class.

Regression in f185d929fa1c0caad8c03fccde899b647d7248c6.

comment:4 Changed 9 months ago by Tim Graham <timograham@…>

In 0991940c:

[2.1.x] Fixed #29959 -- Cached GEOS version in WKBWriter class.

Regression in f185d929fa1c0caad8c03fccde899b647d7248c6.

Backport of e7e55059027ae2f644c852e0ba60dc9307b425e1 from master.

comment:5 Changed 9 months ago by Tim Graham <timograham@…>

In 3cc125b:

[2.0.x] Fixed #29959 -- Cached GEOS version in WKBWriter class.

Regression in f185d929fa1c0caad8c03fccde899b647d7248c6.
Backport of e7e55059027ae2f644c852e0ba60dc9307b425e1 from master.

comment:6 Changed 9 months ago by Tim Graham <timograham@…>

In 216398d:

[1.11.x] Fixed #29959 -- Cached GEOS version in WKBWriter class.

Regression in f185d929fa1c0caad8c03fccde899b647d7248c6.
Backport of e7e55059027ae2f644c852e0ba60dc9307b425e1 from master.

Note: See TracTickets for help on using tickets.
Back to Top