Opened 5 years ago

Closed 5 years ago

#29949 closed Cleanup/optimization (fixed)

DB identifier converters cleanup

Reported by: Mariusz Felisiak Owned by: Mariusz Felisiak
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

IMO we can remove introspection.table_name_converter() and introspection.column_name_converter (unused after #28584) and use instead a single method introspection.identifier_converter(). As a part of this cleanup we will remove features.uppercases_column_names and we'll use introspection.identifier_converter() in the tests suite.

Attachments (1)

29949.diff​ (8.0 KB ) - added by Tim Graham 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by Tim Graham, 5 years ago

Summary: DB identifier converters cleanup. → DB identifier converters cleanup
Triage Stage: Unreviewed → Accepted

I'll attach the initial patch that I worked on. A problem I ran into is that sometimes an inverse of identifier_converter() was needed for some tests.

by Tim Graham, 5 years ago

Attachment: 29949.diff​ added

comment:2 by Mariusz Felisiak, 5 years ago

Owner: changed from nobody to Mariusz Felisiak

comment:3 by Mariusz Felisiak, 5 years ago

Has patch: set

​PR

comment:4 by Tim Graham, 5 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by GitHub <noreply@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In d5f4ce9:

Fixed #29949 -- Refactored db introspection identifier converters.

Removed DatabaseIntrospection.table_name_converter()/column_name_converter()
and use instead DatabaseIntrospection.identifier_converter().

Removed DatabaseFeatures.uppercases_column_names.

Thanks Tim Graham for the initial patch and review and Simon Charette
for the review.

Note: See TracTickets for help on using tickets.
Back to Top