Opened 6 years ago

Last modified 3 weeks ago

#29910 assigned Bug

Allow ManyToManyFields that target proxy models with a through table.

Reported by: Collin Anderson Owned by: Anvansh Singh
Component: Database layer (models, ORM) Version: 2.1
Severity: Normal Keywords:
Cc: cmawebsite@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description (last modified by Collin Anderson)

I'm running into an issue with using ManyToManyFields and Proxy models when the through models reference Proxy classes of the original model.

https://github.com/django/django/pull/10591

According to the ticket's flags, the next step(s) to move this issue forward are:

  • To improve the patch as described in the pull request review comments or on this ticket, then uncheck "Patch needs improvement".
  • If creating a new pull request, include a link to the pull request in the ticket comment when making that update. The usual format is: [https://github.com/django/django/pull/#### PR].

Change History (9)

comment:1 by Tim Graham, 6 years ago

Patch needs improvement: set
Summary: Fix ManyToManyFields with Proxy modelsManyToManyFields that target proxy models don't return the correct model
Triage Stage: UnreviewedAccepted

comment:2 by Asif Saifuddin Auvi, 6 years ago

Patch needs improvement: unset

comment:3 by Tim Graham, 6 years ago

Patch needs improvement: set

My comment requesting more carefully targeted tests isn't addressed.

comment:4 by Collin Anderson, 6 years ago

Patch needs improvement: unset

Ok, I just added some tests.

comment:5 by Collin Anderson, 6 years ago

Description: modified (diff)
Summary: ManyToManyFields that target proxy models don't return the correct modelAllow ManyToManyFields that target proxy models with a through table.

Clarify title/description a little.

comment:6 by Tim Graham, 6 years ago

Patch needs improvement: set

comment:7 by wookkl, 6 months ago

Owner: changed from nobody to wookkl
Status: newassigned

comment:8 by wookkl, 6 months ago

Owner: wookkl removed
Status: assignednew

comment:9 by Anvansh Singh, 3 weeks ago

Owner: set to Anvansh Singh
Status: newassigned
Note: See TracTickets for help on using tickets.
Back to Top