Opened 6 years ago

Closed 6 years ago

#29829 closed Cleanup/optimization (fixed)

Remove unused code in contrib.sites.models._simple_domain_name_validator()

Reported by: Hasan Ramezani Owned by: Hasan Ramezani
Component: contrib.sites Version: 2.1
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There is an if block in _simple_domain_name_validator function that seems there is no need for them because domain field in Site model is not null.

    if not value:
        return

I am going to remove them.

Change History (4)

comment:1 by Hasan Ramezani, 6 years ago

Owner: changed from nobody to Hasan Ramezani
Status: new → assigned

comment:3 by Tim Graham, 6 years ago

Component: Core (Other) → contrib.sites
Summary: Clean `_simple_domain_name_validator` function in django/contrib/sites/models.py → Remove unused code in contrib.sites.models._simple_domain_name_validator()
Triage Stage: Unreviewed → Ready for checkin

comment:4 by Tim Graham <timograham@…>, 6 years ago

Resolution: → fixed
Status: assigned → closed

In f3d3338:

Fixed #29829 -- Remove unused code in contrib.sites.models._simple_domain_name_validator().

Note: See TracTickets for help on using tickets.
Back to Top