Opened 7 years ago
Last modified 7 years ago
#29816 closed Bug
Bug fix for ticket #29138 — at Version 1
| Reported by: | Constantino Schillebeeckx | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | 2.1 |
| Severity: | Normal | Keywords: | autocomplete_fields |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
I've put together a bug fix for the case when autocomplete_fields is used on a foreign-key field that has on_fields specified; bug originally reported here.
Note I've been able to update all unit tests and create some new ones, however the original ticket mentions using to_field_allowed to prevent data leaks. I've tried to implement it (see here), however I can't get it to play nicely with the unit tests. When uncommented, the id_field isn't properly being considered as to_field_allowed. I'm not familiar with this function, so could use some help troubleshooting.