Opened 7 years ago

Closed 7 years ago

#29792 closed Bug (fixed)

GeometryFields do not preserve Oracle specific fields in migrations

Reported by: Jani Tiainen Owned by: Jani Tiainen
Component: GIS Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

GeometryFields do have two attributes that are Oracle specific extent and tolerance when doing migrations both are missing and thus are reset to default values.

Extent affects r-tree generation and tolerance affects some spatial operations.

Change History (8)

comment:1 by Simon Charette, 7 years ago

Component: Uncategorized → GIS
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug
Version: 2.1 → master

I didn't reproduce but the report looks legit by looking at GeometryField.deconstruct.

​https://github.com/django/django/blob/90d93a1b425c0e6e3d88afa9fff78790300e1e38/django/contrib/gis/db/models/fields.py#L239-L246

comment:2 by Tim Graham, 7 years ago

Summary: GeometryFields do not preserve Oracle spesific fields in migrations → GeometryFields do not preserve Oracle specific fields in migrations

comment:3 by Jani Tiainen, 7 years ago

Owner: changed from nobody to Jani Tiainen
Status: new → assigned

comment:4 by Jani Tiainen, 7 years ago

Has patch: set

​PR

comment:5 by Simon Charette, 7 years ago

Patch needs improvement: set

Left some comments for adjustments.

comment:6 by Jani Tiainen, 7 years ago

Patch needs improvement: unset

Second round. Made changes suggested in review.

comment:7 by Mariusz Felisiak, 7 years ago

Triage Stage: Accepted → Ready for checkin

comment:8 by Tim Graham <timograham@…>, 7 years ago

Resolution: → fixed
Status: assigned → closed

In 5a77190e:

Fixed #29792 -- Made GeometryField.deconstruct() handle 'extent' and 'tolerance' args.

Note: See TracTickets for help on using tickets.
Back to Top