Opened 6 months ago

Closed 6 months ago

#29746 closed Bug (fixed)

FlatpageForm help_text is misleading when APPEND_SLASH is False

Reported by: Tom Carrick Owned by: Tom Carrick
Component: contrib.flatpages Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As pointed out by code1 on IRC, when using FlatPageForm when APPEND_SLASH is False, the validation allows URLs without trailing slashes, however the help text still says that a trailing slash is required: "Example: '/about/contact/'. Make sure to have leading and trailing slashes."

Assigning myself, will pick this up if/when it's accepted.

Change History (4)

comment:1 Changed 6 months ago by Tom Carrick

Owner: changed from Tom Carrick to Tom Carrick

comment:2 Changed 6 months ago by Tim Graham

Triage Stage: UnreviewedAccepted

comment:3 Changed 6 months ago by Tom Carrick

Has patch: set

comment:4 Changed 6 months ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In a43cfc23:

Fixed #29746 -- Fixed misleading FlatpageForm URL help text if APPEND_SLASH is disabled.

Note: See TracTickets for help on using tickets.
Back to Top