Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#29677 closed Cleanup/optimization (fixed)

StaticFilesStorage.post_process does not seem to exist, contrary to documentation

Reported by: Atul Varma Owned by: nobody
Component: Documentation Version: 2.1
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The ​documentation for this method states that "This method is called by the collectstatic management command after each run and gets passed the local storages and paths of found files as a dictionary, as well as the command line options."

However, as far as I can tell, this method does not seem to actually exist. I thought perhaps it might be defined on one of its ancestor classes, but it doesn't seem to be... am I mistaken, or is this some kind of method that's optionally implementable by subclasses or something?

Apologies if this is the wrong place to bring this up, or if I am simply confused and do not understand what is going on.

Change History (3)

comment:1 by Tim Graham, 8 years ago

Component: Uncategorized → Documentation
Has patch: set
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization

Adding "If this method is defined on a storage, ..." might be enough clarification? ​PR

comment:2 by Carlton Gibson <carlton.gibson@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In 7f6b013b:

Fixed #29677 -- Doc'd return value of StaticFilesStorage.post_process().

comment:3 by Carlton Gibson <carlton.gibson@…>, 8 years ago

In 5628a8a2:

[2.1.x] Fixed #29677 -- Doc'd return value of StaticFilesStorage.post_process().

Backport of 7f6b013bf60e6168a7e0a8f2b97954c3a45725e0 from master

Note: See TracTickets for help on using tickets.
Back to Top