#29662 closed Cleanup/optimization (fixed)
Test client should accept json types with structured suffixes
| Reported by: | Marnanel Thurman | Owned by: | Zach Bresser |
|---|---|---|---|
| Component: | Testing framework | Version: | 2.1 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
The test client's json() method should permit the Content-Type of the response to contain structured suffixes, such as "application/activity+json".
This requires a regexp such as "^application\/(.+\+)?json".
See RFC 6838 for the specification: https://tools.ietf.org/html/rfc6838#section-4.2.8
An example in the official registry: https://www.iana.org/assignments/media-types/application/activity+json
Issue #27622 provided a partial fix but allowed only vendor-specific prefixes.
Change History (9)
comment:1 by , 7 years ago
| Has patch: | set |
|---|---|
| Needs tests: | set |
| Triage Stage: | Unreviewed → Accepted |
| Type: | Bug → Cleanup/optimization |
comment:2 by , 7 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 7 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 7 years ago
Zach thanks for offer but it looks like there's already a PR that wasn't linked to this ticket
comment:5 by , 7 years ago
| Needs tests: | unset |
|---|
comment:7 by , 7 years ago
| Needs tests: | unset |
|---|
I'm sorry Simon, I didn't realize. I have put in a PR, we make the same changes except I added a note in the Docs too. What is the next step? Close/Merge?
Note:
See TracTickets
for help on using tickets.
If my understanding is correct it should just be the following changes:
Changing
JSON_CONTENT_TYPE_RE = re.compile(r'^application\/(vnd\..+\+)?json')toJSON_CONTENT_TYPE_RE = re.compile(r'^application\/(.+\+)?json'indjango.test.clientAs well as adding some tests. I can take this as my first PR.