Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#29646 closed Cleanup/optimization (fixed)

Document the validators that each model and form field uses

Reported by: Shrey Batra Owned by: Jeff
Component: Documentation Version: 2.1
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no
Pull Requests:10286 merged

Description

URL schemes are missing in the documentation of URLField. SHould be added that only http, https, ftp and ftps are valid. others are not valid.

Change History (11)

comment:1 by Carlton Gibson, 7 years ago

This is mentioned in the URLValidator docs.

comment:2 by Josh Schneier, 7 years ago

EmailField mentions it uses EmailValidator, probably all fields should mention (link to) their default validators in some way.

comment:3 by Tim Graham, 7 years ago

Summary: URL Schemes missing from documentation in URFieldDocument the validators that each model and form field uses
Triage Stage: UnreviewedAccepted

comment:4 by Jeff, 7 years ago

Owner: changed from nobody to Jeff
Status: newassigned

comment:5 by Tim Graham, 7 years ago

Has patch: set
Patch needs improvement: set

PR (which documents only the form field side so far)

comment:6 by Jeff, 7 years ago

Hmm, I thought docs/ref/models/fields.txt, contained the documentation of model fields (which is in the PR as well). I will look through the docs more thoroughly to see if there are more files that contain model fields for documentation.

comment:7 by Tim Graham, 7 years ago

Patch needs improvement: unset

I missed that apparently.

comment:8 by Jeff, 7 years ago

Oh good, I was going a little mad trying to track down the relevant files, haha.

comment:9 by Carlton Gibson, 7 years ago

Triage Stage: AcceptedReady for checkin

comment:10 by Tim Graham <timograham@…>, 7 years ago

Resolution: fixed
Status: assignedclosed

In 3fa3de5:

Fixed #29646 -- Doc'd the validators that each model and form field uses.

comment:11 by Tim Graham <timograham@…>, 7 years ago

In 91af869d:

[2.1.x] Fixed #29646 -- Doc'd the validators that each model and form field uses.

Backport of 3fa3de54152a6b7a67de05ff4ff6fb122c9246e2 from master

Note: See TracTickets for help on using tickets.
Back to Top