Opened 6 years ago
Closed 6 years ago
#29619 closed Cleanup/optimization (fixed)
Raised FieldError's should include the field that caused the error
Reported by: | Alex Hayes | Owned by: | Jeff |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Currently there are many places in django/db/models/sql/compiler.py that raise a FieldError
however frustratingly the field that caused the error is not included.
I'm proposing that, where possible, all raised FieldError
's raised should include, as part of the error message, the field that caused the error.
Change History (9)
comment:1 by , 6 years ago
Triage Stage: | Unreviewed → Accepted |
---|---|
Version: | 2.0 → master |
follow-up: 3 comment:2 by , 6 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 6 years ago
comment:4 by , 6 years ago
Hi Shrey, sorry for the delay in getting back to you. I would still be happy to have you work on it with me if you are still interested.
comment:5 by , 6 years ago
Has patch: | set |
---|---|
Patch needs improvement: | set |
PR (some test coverage is lacking)
comment:6 by , 6 years ago
Can I take this issue forward ? If yes then I would assign this issue to myself and will add the test cases required.
comment:8 by , 6 years ago
Patch needs improvement: | unset |
---|
Replying to Jeff:
Hello Jeff, I may be able to help you in patching this. Will you continue or could we work together?