#29593 closed Bug (fixed)
Removal of QUERY_TERMS is not in 2.1 "features removed" page
| Reported by: | Ryan Verner | Owned by: | Carlton Gibson |
|---|---|---|---|
| Component: | Documentation | Version: | 2.1 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
django.db.models.sql.constants.QUERY_TERMS is removed in the upcoming 2.1;
https://github.com/django/django/commit/244cc401559e924355cf943b6b8e66ccf2f6da3a (edit: fixed correct commit)
There is no mention of this in the release notes:
https://docs.djangoproject.com/en/2.1/releases/2.1/#features-removed-in-2-1
Lots of projects reference this, and will break when upgrading to 2.1 (Wagtail is one; I'm prepping a PR for them).
https://github.com/search?l=Python&q=from+django.db.models.sql.constants+import+QUERY_TERMS&type=Code
Change History (13)
comment:1 by , 6 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 6 years ago
QUERY_TERMS was removed in 244cc401559e924355cf943b6b8e66ccf2f6da3a for #26184.
comment:3 by , 6 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:5 by , 6 years ago
| Has patch: | set |
|---|
comment:6 by , 6 years ago
| Description: | modified (diff) |
|---|
comment:7 by , 6 years ago
Carlton: Thanks for linking to the correct commit; that's what I was looking at but I linked to a different one for some reason. Changes look good to me - indeed it's not a public API but the GitHub search above indicates it's used quite a bit.
comment:10 by , 6 years ago
Hey, did this not make it into the official documentation? I assumed that would be automatically generated from the repo.
This isn't mentioned on this page, which is where people will generally be looking for upgrade/depreciation advice - https://docs.djangoproject.com/en/2.1/releases/2.1/
comment:12 by , 6 years ago
Ryan, it should eventually show up. I just did the backport to the stable/2.1.x branch.
QUERY_TERMSwas never documented as public API. As such it's not a Feature per se, and is not subject to the deprecation policy.Having said that, I'm not unsympathetic to people running into this. (Amongst others django-filter needed to make changes to work around it.)
It has been widely used; we should probably mention it. Perhaps in Backwards incompatible changes in 2.1 > Miscellaneous.