Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#29536 closed Bug (fixed)

SelectFilter2.js boxes don't resize to have equal height

Reported by: Claude Paroz Owned by: Claude Paroz
Component: contrib.admin Version: 2.0
Severity: Normal Keywords: regression
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

SelectFilter2.js has some code to resize select boxes to the same height in horizontal mode.
https://github.com/claudep/django/blob/78912ccd0e1fcdfe98ca85081c9eb8acb7aa1f6d/django/contrib/admin/static/admin/js/SelectFilter2.js#L166

Obviously this doesn't work any more. JS coder needed!

Attachments (2)

Capture d'écran de 2018-06-29 16-03-50.png (31.5 KB ) - added by Claude Paroz 6 years ago.
What it used to look like
Capture d'écran de 2018-06-29 16-03-42.png (27.7 KB ) - added by Claude Paroz 6 years ago.
Current look with size mismatch

Download all attachments as: .zip

Change History (7)

by Claude Paroz, 6 years ago

What it used to look like

by Claude Paroz, 6 years ago

Current look with size mismatch

comment:1 by Claude Paroz, 6 years ago

Owner: changed from nobody to Claude Paroz
Status: newassigned

I think I can handle this.

comment:2 by Claude Paroz, 6 years ago

Has patch: set
UI/UX: set

comment:3 by Tim Graham, 6 years ago

Summary: SelectFilter2.js box resizing code has no effectSelectFilter2.js boxes don't resize to have equal height
Triage Stage: AcceptedReady for checkin

comment:4 by Claude Paroz <claude@…>, 6 years ago

Resolution: fixed
Status: assignedclosed

In a5f13923:

Fixed #29536 -- Fixed SelectFilter2.js resizing to make boxes have equal height.

Thanks Tim Graham for the review.

comment:5 by Claude Paroz <claude@…>, 6 years ago

In 58a0a84c:

[2.1.x] Fixed #29536 -- Fixed SelectFilter2.js resizing to make boxes have equal height.

Thanks Tim Graham for the review.
Backport of a5f139236f930df06ae0642507530ca98081e2a9 from master.

Note: See TracTickets for help on using tickets.
Back to Top