Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#29498 closed Bug (fixed)

2.1~alpha1 release tarball missing tests/migrations/test_migrations_bad_pyc/0001_initial.pyc causing test failure

Reported by: Chris Lamb Owned by: nobody
Component: Packaging Version: 2.1
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Hi,

The 2.1~alpha1 release tarball is missing the tests/migrations/test_migrations_bad_pyc/0001_initial.pyc file causing a testsuite failure:

======================================================================
FAIL: test_invalid (migrations.test_loader.PycLoaderTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.6/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/usr/lib/python3.6/unittest/case.py", line 605, in run
    testMethod()
  File "/build/python-django-2.1~alpha1/tests/migrations/test_loader.py", line 530, in test_invalid
    MigrationLoader(connection)
  File "/usr/lib/python3.6/unittest/case.py", line 203, in __exit__
    self._raiseFailure("{} not raised".format(exc_name))
  File "/usr/lib/python3.6/unittest/case.py", line 135, in _raiseFailure
    raise self.test_case.failureException(msg)
AssertionError: ImportError not raised

----------------------------------------------------------------------
Ran 12306 tests in 105.822s

FAILED (failures=1, skipped=823, expected failures=4)

(This is likely due to global-exclude *.py[co] in ./MANIFEST.in. I wonder if this file should be generated by the tests itself)

Change History (3)

comment:1 Changed 13 months ago by Tim Graham

Has patch: set
Severity: NormalRelease blocker
Triage Stage: UnreviewedAccepted
Type: UncategorizedBug
Version: 2.02.1

I agree it would be better not to include a pyc file. I also encountered trouble with that because I had a git checkout hook that deleted pyc files.

PR

comment:2 Changed 13 months ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In 63f90f55:

Fixed #29498 -- Fixed a missing pyc test file in source distribution.

comment:3 Changed 13 months ago by Tim Graham <timograham@…>

In 7f173b6:

[2.1.x] Fixed #29498 -- Fixed a missing pyc test file in source distribution.

Backport of 63f90f55f30d599d601d729060cdb0ebd2abdeb8 from master

Note: See TracTickets for help on using tickets.
Back to Top