#29468 closed Cleanup/optimization (wontfix)
Allow overriding a widget's attributes without redeclaring the default widget
Reported by: | Ivan Muller | Owned by: | nobody |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Normal | Keywords: | Field Widget html attrs |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
Hi guys, I want to improve the way of declear html attrs into a Fields With out declaring the default widget again.
Example:
class ProfileForm(forms.ModelForm): class Meta: model = Profile full_name = forms.CharField(widget=forms.TextInput(attrs={'class': Anyclass',}))
As Field documentaiton say into the init:
"""Each Field has a default Widget that it'll use if you don't specify this. n most cases, the default widget is TextInput:"""
Woudl be god to declare it as
full_name = forms.CharField(widget_attrs={'class': Anyclass',})
Change History (5)
comment:1 by , 6 years ago
Description: | modified (diff) |
---|
comment:2 by , 6 years ago
comment:3 by , 6 years ago
Description: | modified (diff) |
---|---|
Resolution: | → wontfix |
Status: | new → closed |
Summary: | Form Field declaration: → Improve Form Field declaration of widget `attrs`. |
Hi @mullerivan,
The docs for Styling widget instances give three approaches. The one you'd like to avoid is just the first.
In your case, I guess I'd recommend the second approach, to adjust the widget attrs inline in the form definition:
class ProfileForm(forms.ModelForm): full_name = forms.CharField() full_name.widget.attrs.update({'class': 'Anyclass',}) class Meta: model = Profile
Given that multiple options already exist, adding yet another keyword argument is not going to be worth it on balance.
(The benefit won't justify the extra API surface area.)
Also see the ModelForm
docs on Overriding default fields. If it's API you really want in your project there's nothing to stop you creating a base form class or mixin the takes an additional extra_widget_attrs
and sets that appropriately during __init__()
, as a generalisation of the third strategy outlined in the Styling widget instances docs linked above.
comment:4 by , 6 years ago
Summary: | Improve Form Field declaration of widget `attrs`. → Allow overriding a widget's attributes without redeclaring the default widget |
---|
comment:5 by , 6 years ago
Thanks a lot! im actually likes the way that you define to handle this scenario
Cheers
Maybe that easy hack may help