Changes between Initial Version and Version 1 of Ticket #29428, comment 5


Ignore:
Timestamp:
06/06/2018 03:20:08 AM (2 years ago)
Author:
Carlton Gibson
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #29428, comment 5

    initial v1  
    1313The ordering works without the `asc()` call (or the `F` for that matter) so maybe `get_ordering_field_columns()` should call `field.asc()` (if available, when not already an `OrderBy`) in order to correct the behaviour here.
    1414
    15 Second, whilst you can an `ordering` including (say) `Lower('description')` on the model, if you try to set it on the ModelAdmin, the admin's [https://github.com/django/django/blob/b37bac39b387bc87872d37d4b07783b67ef28d0c/django/contrib/admin/checks.py#L476 `_check_ordering` check] will error (in `LOOKUP_SEP in field_name`). This occurs in for the transform or `OrderBy` case. This check needs adjusting.
     15Second, whilst you can set an `ordering` including (say) `Lower('description')` on the model, if you try to set it on the ModelAdmin, the admin's [https://github.com/django/django/blob/b37bac39b387bc87872d37d4b07783b67ef28d0c/django/contrib/admin/checks.py#L476 `_check_ordering` check] will error (in `LOOKUP_SEP in field_name`). This occurs in for the transform or `OrderBy` case. This check needs adjusting.
    1616
    1717@Nicolas Noé Are you good to work on this ticket still?
Back to Top