Changes between Initial Version and Version 1 of Ticket #29428, comment 5
- Timestamp:
- Jun 6, 2018, 3:20:08 AM (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #29428, comment 5
initial v1 13 13 The ordering works without the `asc()` call (or the `F` for that matter) so maybe `get_ordering_field_columns()` should call `field.asc()` (if available, when not already an `OrderBy`) in order to correct the behaviour here. 14 14 15 Second, whilst you can an `ordering` including (say) `Lower('description')` on the model, if you try to set it on the ModelAdmin, the admin's [https://github.com/django/django/blob/b37bac39b387bc87872d37d4b07783b67ef28d0c/django/contrib/admin/checks.py#L476 `_check_ordering` check] will error (in `LOOKUP_SEP in field_name`). This occurs in for the transform or `OrderBy` case. This check needs adjusting.15 Second, whilst you can set an `ordering` including (say) `Lower('description')` on the model, if you try to set it on the ModelAdmin, the admin's [https://github.com/django/django/blob/b37bac39b387bc87872d37d4b07783b67ef28d0c/django/contrib/admin/checks.py#L476 `_check_ordering` check] will error (in `LOOKUP_SEP in field_name`). This occurs in for the transform or `OrderBy` case. This check needs adjusting. 16 16 17 17 @Nicolas Noé Are you good to work on this ticket still?