Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#29417 closed Bug (fixed)

Admin title still says "Change [model]" when user has view-only permission

Reported by: Matthew Frazier Owned by: Ramiro Morales
Component: contrib.admin Version: 2.1
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description

When the admin user has the "view" permission for a model but doesn't have the "change" permission, the title of the change view still says "Change [model]", and the title of the change list view still says "Select [model] to change." Since the admin index page displays "View" instead of "Change" on the link to the changelist when the user only has the view permission, it would make sense to change the title of the changelist and change views as well.

Attachments (2)

Django bug report - Change on view-only changelist.png (124.7 KB) - added by Matthew Frazier 6 months ago.
Screenshot on changelist view
Django bug report - Change on view-only page.png (59.3 KB) - added by Matthew Frazier 6 months ago.
Screenshot on change view

Download all attachments as: .zip

Change History (9)

Changed 6 months ago by Matthew Frazier

Screenshot on changelist view

Changed 6 months ago by Matthew Frazier

Screenshot on change view

comment:1 Changed 6 months ago by Tim Graham

Severity: NormalRelease blocker
Triage Stage: UnreviewedAccepted

comment:2 Changed 6 months ago by Paulo

Owner: changed from nobody to Paulo
Status: newassigned

comment:3 Changed 6 months ago by Ramiro Morales

Ugh. forgot to assign this to myself.

I have a patch almost ready for review. Will open a PR for you to peruse in a few minutes.

comment:4 Changed 6 months ago by Paulo

Owner: Paulo deleted
Status: assignednew

No worries, unassigned myself :)

comment:5 Changed 6 months ago by Ramiro Morales

Has patch: set
Owner: set to Ramiro Morales
Status: newassigned

PR

Open question: What the titles/headers shoudl be if the user has permission to both view and delete an object? 'Change article' doesn't sound completely correct, but neither does 'View article'.

comment:6 Changed 6 months ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In f40e71a:

Fixed #29417 -- Corrected two admin page titles for view-only users.

comment:7 Changed 6 months ago by Tim Graham <timograham@…>

In c56d94c:

[2.1.x] Fixed #29417 -- Corrected two admin page titles for view-only users.

Backport of f40e71a957aa00b4572c19b269179cded6c8c500 from master

Note: See TracTickets for help on using tickets.
Back to Top