#29417 closed Bug (fixed)
Admin title still says "Change [model]" when user has view-only permission
Reported by: | Matthew Frazier | Owned by: | Ramiro Morales |
---|---|---|---|
Component: | contrib.admin | Version: | 2.1 |
Severity: | Release blocker | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | yes |
Description
When the admin user has the "view" permission for a model but doesn't have the "change" permission, the title of the change view still says "Change [model]", and the title of the change list view still says "Select [model] to change." Since the admin index page displays "View" instead of "Change" on the link to the changelist when the user only has the view permission, it would make sense to change the title of the changelist and change views as well.
Attachments (2)
Change History (9)
by , 6 years ago
Attachment: | Django bug report - Change on view-only changelist.png added |
---|
by , 6 years ago
Attachment: | Django bug report - Change on view-only page.png added |
---|
Screenshot on change view
comment:1 by , 6 years ago
Severity: | Normal → Release blocker |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 6 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 6 years ago
Ugh. forgot to assign this to myself.
I have a patch almost ready for review. Will open a PR for you to peruse in a few minutes.
comment:5 by , 6 years ago
Has patch: | set |
---|---|
Owner: | set to |
Status: | new → assigned |
Open question: What the titles/headers shoudl be if the user has permission to both view and delete an object? 'Change article' doesn't sound completely correct, but neither does 'View article'.
Screenshot on changelist view