#2940 closed defect (fixed)
[patch] settings.MANAGERS does not default to settings.ADMINS
| Reported by: | Owned by: | Jacob | |
|---|---|---|---|
| Component: | Documentation | Version: | dev | 
| Severity: | minor | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no | 
| Needs tests: | no | Patch needs improvement: | no | 
| Easy pickings: | no | UI/UX: | no | 
Description
The settings documentation notes that MANAGERS defaults to ADMINS.  Alas, this isn't true.
So what actually happens?  Well, in django.conf.global_settings, MANAGERS is set to equal ADMINS — an empty tuple.  But when ADMINS is set in a project's settings file MANAGERS remains an empty tuple.
There are two solutions.  The first, and by far simplest, is to change the documentation to note that MANAGERS defaults to an empty tuple.  The second is to modify the code in django.conf to make a special case of MANAGERS (and perhaps other settings) so that it is changed to equal the project's settings.ADMINS if empty.  I'll attach the first solution as a patch.
That wasn't the easiest thing to explain, but I hope it makes sense.
Attachments (1)
Change History (4)
by , 19 years ago
| Attachment: | settings.txt.diff added | 
|---|
comment:1 by , 19 years ago
| Summary: | settings.MANAGERS does not default to settings.ADMINS → [patch] settings.MANAGERS does not default to settings.ADMINS | 
|---|
Patch to make a minor change to the documentation on settings.MANAGERS