Code

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2940 closed defect (fixed)

[patch] settings.MANAGERS does not default to settings.ADMINS

Reported by: matt.riggott@… Owned by: jacob
Component: Documentation Version: master
Severity: minor Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The settings documentation notes that MANAGERS defaults to ADMINS. Alas, this isn't true.

So what actually happens? Well, in django.conf.global_settings, MANAGERS is set to equal ADMINS — an empty tuple. But when ADMINS is set in a project's settings file MANAGERS remains an empty tuple.

There are two solutions. The first, and by far simplest, is to change the documentation to note that MANAGERS defaults to an empty tuple. The second is to modify the code in django.conf to make a special case of MANAGERS (and perhaps other settings) so that it is changed to equal the project's settings.ADMINS if empty. I'll attach the first solution as a patch.

That wasn't the easiest thing to explain, but I hope it makes sense.

Attachments (1)

settings.txt.diff (424 bytes) - added by matt.riggott@… 7 years ago.
Patch to make a minor change to the documentation on settings.MANAGERS

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by matt.riggott@…

Patch to make a minor change to the documentation on settings.MANAGERS

comment:1 Changed 7 years ago by anonymous

  • Summary changed from settings.MANAGERS does not default to settings.ADMINS to [patch] settings.MANAGERS does not default to settings.ADMINS

comment:2 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [3923].

comment:3 Changed 7 years ago by anonymous

  • milestone Version 1.0 deleted

Milestone Version 1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.