Opened 7 years ago

Closed 7 years ago

#29275 closed Cleanup/optimization (fixed)

Emit "(actual errors: none)" instead of "(actual errors: )" in assertFormError

Reported by: Chris Lamb Owned by: nobody
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Chris Lamb)

The suffix in the error output of assertFormError (eg.)

AssertionError: False is not true : The form 'form' in context 0 does not contain the non-field error 'Please enter a correct email and password. Note that both fields may be case-sensitive.' (actual errors: )

is kinda weird. We should print "none" instead, otherwise it looks like there is an error in the error.

Change History (3)

comment:1 by Chris Lamb, 7 years ago

Description: modified (diff)
Has patch: set
Summary: Emit "(actual errors: none)" instead of "(actual errors: )" → Emit "(actual errors: none)" instead of "(actual errors: )" in assertFormError

​https://github.com/django/django/pull/9837

comment:2 by Claude Paroz, 7 years ago

Triage Stage: Unreviewed → Ready for checkin
Version: 2.0 → master

comment:3 by Tim Graham <timograham@…>, 7 years ago

Resolution: → fixed
Status: new → closed

In 84ad721:

Fixed #29275 -- Made assertFormError() output "(actual errors: none)" instead of "(actual errors: )".

Note: See TracTickets for help on using tickets.
Back to Top