makemessages doesn't parse ES6 template strings

[Artem Skoretskiy]

ECMAScript 6 introduced template strings, that are easy to use ​https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

But Django 2.0.2 does not recognize it when it tries to extract translations into PO file. It also gives you a warning in some cases.

Demo:

# main.js

let header = `${_("Header")}`;

const get_url = id => `/my_user/${id}/`;

let header_old = _("Header old");

Run:

./manage.py makemessages -d djangojs -a

PO file would contain only "Header old".

This is a synthetic example, you could see real-life file attached. It would generate following warnings:

api.js:90: warning: unterminated string
api.js:139: warning: RegExp literal terminated too early

As far as I get, it ignores back-ticks and treats content as regular expression here.

[Artem Skoretskiy]

Sample ES6 file that raises a warning

[Tim Graham]

Isn't this an ​xgettext issue rather than something Django can solve?

[Claude Paroz]

Same as #29174, I even found the gettext bug report: ​https://savannah.gnu.org/bugs/?50920

[Claude Paroz]

Tentative doc patch

[Claude Paroz]

Draft patch attached for resolving both #29175 and #29174.

[Tim Graham]

That looks okay. I create a ​PR. One comment there.

[Carlton Gibson <carlton.gibson@…>]

In c3437f73:

Fixed #29174, #29175 -- Doc'd that f-strings and JavaScript template strings can't be translated.

[Carlton Gibson <carlton.gibson@…>]

In 8b4798c:

[1.11.x] Fixed #29174, #29175 -- Doc'd that f-strings and JavaScript template strings can't be translated.

Backport of c3437f734d03d93f798151f712064394652cabed from master

[Carlton Gibson <carlton.gibson@…>]

In 0d2ec8d:

[2.0.x] Fixed #29174, #29175 -- Doc'd that f-strings and JavaScript template strings can't be translated.

Backport of c3437f734d03d93f798151f712064394652cabed from master

[Carlton Gibson <carlton.gibson@…>]

In a5d1fe5:

Revert "[1.11.x] Fixed #29174, #29175 -- Doc'd that f-strings and JavaScript template strings can't be translated."

This reverts commit 8b4798c8d31b3cd9faab4caf11fca000b07f0181.