Opened 6 years ago

Closed 6 years ago

#29048 closed Cleanup/optimization (fixed)

Add **extra_context arg to as_vendor methods in database functions

Reported by: Matthew Pava Owned by: Priyansh Saxena
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description (last modified by Matthew Pava)

Func inherits from SQLiteNumericMixin, which added an extra argument to as_sqlite: **extra_context. PyCharm flags the database functions that inherit from Func because their as_sqlite methods do not have that extra argument.

Change History (8)

comment:1 by Tim Graham, 6 years ago

Easy pickings: unset

Is there a concrete problem? It's unclear what "Based on feedback from other developers" refers to.

comment:2 by Matthew Pava, 6 years ago

Description: modified (diff)

I updated the description to describe the problem in better detail.

When I was working on PR 9583, a contributor made this comment when I had unintentionally made the changes to other classes not related to that PR:

I've also noticed a warning in Pycharm that the signature of as_sqlite and as_oracle doesn't match the superclass. I'd guess it's better to deal with this in a different PR.

I assumed that the contributor was speaking on behalf of "other developers."

comment:3 by Tim Graham, 6 years ago

Triage Stage: UnreviewedAccepted

But there's no concrete issue, correct? I suppose we can change those signatures, even if it's just fix the PyCharm warnings.

comment:4 by Matthew Pava, 6 years ago

Correct, Tim.

comment:5 by Priyansh Saxena, 6 years ago

Owner: changed from nobody to Priyansh Saxena
Status: newassigned

comment:6 by Priyansh Saxena, 6 years ago

Has patch: set

comment:7 by Tim Graham, 6 years ago

Patch needs improvement: set

comment:8 by Tim Graham <timograham@…>, 6 years ago

Resolution: fixed
Status: assignedclosed

In 83b04d4:

Fixed #29048 -- Added extra_context to database function as_vendor() methods.

Note: See TracTickets for help on using tickets.
Back to Top