Opened 21 months ago

Closed 2 months ago

#29043 closed Cleanup/optimization (wontfix)

test --keepdb says "Using existing test database" even if it's run for the first time

Reported by: karyon Owned by: Hasan Ramezani
Component: Database layer (models, ORM) Version: 2.0
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by karyon)

The title says it, test --keepdb says Using existing test database for alias even if that option hasn't been used before and there is no db to reuse.

besides, in my project the full output is

Using existing test database for alias 'default'...
Cache table 'evap_db_cache' already exists.
System check identified no issues (0 silenced).
<snip>

i think the second line is weird and provides no value, i think it can simply be removed.

Change History (8)

comment:1 Changed 21 months ago by karyon

Description: modified (diff)

comment:2 Changed 21 months ago by Tim Graham

Component: UncategorizedDatabase layer (models, ORM)
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

I'm not sure that fixing this won't add more complexity than it's worth, but we could evaluate a patch.

comment:3 Changed 5 months ago by Hasan Ramezani

Has patch: set
Needs tests: set
Owner: changed from nobody to Hasan Ramezani
Status: newassigned

The patch needs tests. I don't know how to test it.
Any suggestion?

comment:4 Changed 4 months ago by Hasan Ramezani

Needs tests: unset

Tests added

comment:5 Changed 4 months ago by Carlton Gibson

Patch needs improvement: set

As per comments on the PR, I agree with Tim's original comment: the extra code added just isn't worth the benefit.

We catch exceptions from _execute_create_test_db(). Maybe we could add some additional output in the if keepdb branch there, just to clarify the existing message.

comment:6 Changed 4 months ago by Hasan Ramezani

@Carlton Gibson, Thanks for the comment.

I checked Django database backends creation.py and the exception in _execute_create_test_db() just raise in base and MySQL backend.
In Postgres backend, it checks the database assistance and doesn't raise an exception:
`

    def _execute_create_test_db(self, cursor, parameters, keepdb=False):
        try:
            if keepdb and self._database_exists(cursor, parameters['dbname']):
                # If the database should be kept and it already exists, don't
                # try to create a new one.
                return

In Oracle backend we don't have the _execute_create_test_db(), Oracle backend has it's own _create_test_db and doesn't call the _execute_create_test_db().

So, it seems your proposed solution
`

Maybe we could add some additional output in the if keepdb branch there, just to clarify the existing message.

'
will add extra code but less than my first solution.

I have another idea, we can clarify the message at the first point. here is the solution:

diff --git a/django/db/backends/base/creation.py b/django/db/backends/base/creation.py
index f36d60a5fe..cdf092967a 100644
--- a/django/db/backends/base/creation.py
+++ b/django/db/backends/base/creation.py
@@ -45,9 +45,10 @@ class BaseDatabaseCreation:
             if keepdb:
                 action = "Using existing"
 
-            self.log('%s test database for alias %s...' % (
+            self.log('%s test database for alias %s%s...' % (
                 action,
                 self._get_database_display_str(verbosity, test_database_name),
+                '(if exists)' if keepdb else '',
             ))
 
         # We could skip this call if keepdb is True, but we instead

What is your opinion about this?

comment:7 Changed 2 months ago by Hasan Ramezani

Patch needs improvement: unset

comment:8 Changed 2 months ago by felixxm

Resolution: wontfix
Status: assignedclosed

After evaluating proposed patches I have to say that it's not worth to add a complexity here.

Note: See TracTickets for help on using tickets.
Back to Top