Opened 6 years ago
Closed 6 years ago
#28971 closed Cleanup/optimization (fixed)
EmailMessage.message() does not override Cc header from extra_headers dict (unlike From, To, and Reply-To)
| Reported by: | Jon Dufresne | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Mail) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Compare how CC is built:
https://github.com/django/django/blob/2.0/django/core/mail/message.py#L259
To how the other headers are built:
- https://github.com/django/django/blob/2.0/django/core/mail/message.py#L256
- https://github.com/django/django/blob/2.0/django/core/mail/message.py#L257
- https://github.com/django/django/blob/2.0/django/core/mail/message.py#L261
Notice, unlike the others, Cc does not first use the .extra_headers dict. Like the other headers, should be able to use the .extra_headers to override Cc.
Change History (3)
comment:1 by , 6 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 6 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:3 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
In b03d5002: