Opened 11 days ago

Closed 11 days ago

Last modified 11 days ago

#28890 closed Bug (fixed)

Broken layout due to whitespace in multiwidget rendering

Reported by: Nick Pope Owned by: Nick Pope
Component: Forms Version: 1.11
Severity: Normal Keywords: whitespace, multiwidget, widgets
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Since upgrading to 1.11, due to the addition of template-based widget rendering in #15667, I've experienced some form layouts breaking.

This is due to the way that white-space is handled in the templates which was previously not an issue when strings were being joined in MultiWidget.format_output().

This may well affect more than MultiWidget.

See the attached screenshot - top is how things looked before, bottom is how things look after upgrading to 1.11.

Attachments (1)

multiwidget-spacing-bug.png (7.3 KB) - added by Nick Pope 11 days ago.

Download all attachments as: .zip

Change History (5)

Changed 11 days ago by Nick Pope

Attachment: multiwidget-spacing-bug.png added

comment:1 Changed 11 days ago by Claude Paroz

Triage Stage: UnreviewedAccepted

comment:2 Changed 11 days ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In e014f91:

Fixed #28890 -- Removed newlines between MultiWidget's subwidgets.

Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.

comment:3 Changed 11 days ago by Tim Graham <timograham@…>

In c1d57615:

[2.0.x] Fixed #28890 -- Removed newlines between MultiWidget's subwidgets.

Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.

Backport of e014f91a70aa3ccdddb363a733c76e35597424fa from master

comment:4 Changed 11 days ago by Tim Graham <timograham@…>

In 47681af3:

[1.11.x] Fixed #28890 -- Removed newlines between MultiWidget's subwidgets.

Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.

Backport of e014f91a70aa3ccdddb363a733c76e35597424fa from master

Note: See TracTickets for help on using tickets.
Back to Top