Opened 8 months ago

Closed 6 months ago

Last modified 6 months ago

#28885 closed Bug (fixed)

Bottom parts of "Congratulations!" page cut off internationalized content

Reported by: Maciej Olko Owned by: Himanshu Chauhan
Component: Core (Other) Version: 2.0
Severity: Normal Keywords: i18n, template, defaults
Cc: Timothy Allen Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description (last modified by Maciej Olko)

Bottom parts (footer) of "Congratulations!" page[1] (rocket taking off/default urlconf) cut off text if it is too long. It happens for e.g. Russian and Lower Serbian languages. Screenshots:
https://screenshots.firefox.com/H4OzOchrVQCvNp5e/localhost
https://screenshots.firefox.com/dG8BTsWHB4s0F2pL/localhost

For many other languages, the problem is more of just esthetic nature, as the padding to the bottom of page is not equal to padding to the footer top ruler (if translations aren't one-liners in effect).

The footer shouldn't have fixed height. I am afraid that some JavaScript is neccessary to calculate footer's height if we are about to keep the layout.

[1] django/django/views/templates/default_urlconf.html

Change History (11)

comment:1 Changed 8 months ago by Claude Paroz

Cc: Timothy Allen added
Triage Stage: UnreviewedAccepted

comment:2 Changed 8 months ago by Timothy Allen

Owner: changed from nobody to Timothy Allen
Status: newassigned

We will tweak the design so it works in more languages, and test with Google Translate. Thanks for the catch!

comment:3 Changed 8 months ago by Maciej Olko

Description: modified (diff)

You can also test it with official Django translations, by just changing the LANGUAGE_CODE setting. Language codes that have longest translations (AFAIK) are "ru" and "dsb".

comment:4 Changed 6 months ago by Himanshu Chauhan

I have tweaked the CSS of the web page so that it does not change original design and fix the mentioned bug. Can I claim this ticket and submit the patch?

comment:5 in reply to:  4 Changed 6 months ago by Timothy Allen

Replying to Himanshu Chauhan:

I have tweaked the CSS of the web page so that it does not change original design and fix the mentioned bug. Can I claim this ticket and submit the patch?

Absolutely! My colleague and I were working on a fix, but if you've got something complete, by all means take the ticket and issue a P.R. Thanks so much!

comment:6 Changed 6 months ago by Timothy Allen

Owner: Timothy Allen deleted
Status: assignednew

comment:7 Changed 6 months ago by Himanshu Chauhan

Owner: set to Himanshu Chauhan
Status: newassigned

comment:8 Changed 6 months ago by Himanshu Chauhan

Has patch: set

comment:9 Changed 6 months ago by Carlton Gibson

Triage Stage: AcceptedReady for checkin

The patch looks good. (Screenshots on PR)

The commit message does not quite match the guidelines, but could be adjusted when merging.

Need to confirm Himanshu submitted the CLA.

Update: both these queries addressed in PR https://github.com/django/django/pull/9570#issuecomment-356871766

Last edited 6 months ago by Carlton Gibson (previous) (diff)

comment:10 Changed 6 months ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 1b753b2:

Fixed #28885 -- Fixed hidden content at the bottom of the "The install worked successfully!" page for some languages.

comment:11 Changed 6 months ago by Tim Graham <timograham@…>

In cc1bdce6:

[2.0.x] Fixed #28885 -- Fixed hidden content at the bottom of the "The install worked successfully!" page for some languages.

Backport of 1b753b2d60230974e7d537ddacbcc1ad23348e7c from master

Note: See TracTickets for help on using tickets.
Back to Top