Opened 7 years ago

Closed 6 years ago

#28767 closed Bug (fixed)

Incorrect value when annotating empty list as Value() on ArrayField.

Reported by: Matthew Schinckel Owned by:
Component: contrib.postgres Version: 2.2
Severity: Normal Keywords: annotate
Cc: Tomer Chachamu Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I have a nice simple minimal case that shows this.

You can try this on any model: auth.User was just convenient for example. You'll need at least one object in there to query.

from django.contrib.auth.models import User
from django.contrib.postgres.fields import ArrayField
from django.db.models.expressions import Value
from django.db.models import IntegerField

User.objects.annotate(foo=Value([1], output_field=ArrayField(IntegerField()))).first().foo
# Outputs [1], as expected

User.objects.annotate(foo=Value([], output_field=ArrayField(IntegerField()))).first().foo
# Outputs '{}', which is _not_ correct.

Change History (6)

comment:1 by Matthew Schinckel, 7 years ago

Still a problem in current development head.

Last edited 7 years ago by Matthew Schinckel (previous) (diff)

comment:2 by Tim Graham, 7 years ago

Triage Stage: Unreviewed → Accepted

#28762 may be related if not a duplicate.

comment:3 by Tomer Chachamu, 7 years ago

I added a test in #28762 for this.

Version 0, edited 7 years ago by Tomer Chachamu (next)

comment:4 by Tomer Chachamu, 7 years ago

Cc: Tomer Chachamu added

comment:5 by GitHub <noreply@…>, 6 years ago

In 654614b3:

Refs #28767 -- Added test for annotating Value() with empty list as an ArrayField.

Fixed in 3af695eda24b874486ee8be7e0d729761b3bdc71.

comment:6 by Mariusz Felisiak, 6 years ago

Resolution: → fixed
Status: new → closed
Version: 1.11 → 2.2

Fixed in 3af695eda24b874486ee8be7e0d729761b3bdc71.

Note: See TracTickets for help on using tickets.
Back to Top