Add route information to ResolverMatch

[Benjamin Wohlwend]

The new route-based URL patterns are fantastic, but when introspecting the ResolverMatch object, the route information is not available. The route would be of great use for tools/libraries that need to introspect the URL resolver.

GitHub PR with a first try at adding this will follow.

[Benjamin Wohlwend]

PR: ​https://github.com/django/django/pull/9323

[Tomer Chachamu]

Thanks for the patch. If it's ready to review you can deassign the Trac ticket. :)

[Tim Graham]

For URL patterns that use re_path() is the route already available from ResolverMatch? If not, I'm unsure why this attribute would only be set for path().

(By the way, there's no need to deassign the ticket to get it in the review queue.)

[Benjamin Wohlwend]

Replying to Tim Graham:

For URL patterns that use re_path() is the route already available from ResolverMatch? If not, I'm unsure why this attribute would only be set for path().

re_path() uses RegexPattern, which doesn't have a route, but a regex. Do you think the regex should be set in that case? That would simplify the code a bit. Instead of getattr(pattern._route), we could just use str(pattern) (__str__ prints _route for RoutePattern objects, and _regex for RegexPattern).

[Tim Graham]

Yes, that's what I meant to suggest.

[Benjamin Wohlwend]

OK. However, in that case I think the attribute on ResolverMatch should be named differently, since AFAICT, "route" is specific to the new simplified URLs from DEP 201. Maybe ResolverMatch.pattern?

[Tim Graham]

The first argument of re_path() is also documented as route so I think it's okay to use that.

[Melvyn Sopacua]

Working on patch + test + docs.

@tim Do I need to submit a new document for contribution or can you link the one I submitted already to this [github account](​https://github.com/mes3yd/)? The old account will get closed as soon as there's nothing pending on it anymore.

[Tim Graham]

You don't need to submit another Contributor License Agreement. Those agreements are linked to you, not to your GitHub account.

[Tim Graham]

​PR with comments for improvement.

[Tim Graham <timograham@…>]

In 79c196cf:

Fixed #28766 -- Added ResolverMatch.route.

Co-Authored-By: Xavier Fernandez <xavier.fernandez@…>