Opened 6 months ago

Closed 2 months ago

#28755 closed Bug (fixed)

django.utils.translation.check_for_language doesn't check in the app folders

Reported by: Dorian Amouroux Owned by: ChillarAnand
Component: Internationalization Version: 1.11
Severity: Normal Keywords:
Cc: ChillarAnand Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When using the set_language view to set the language for the user, it doesn't work if the language file is not in settings.LOCALE_PATHS nor in django/conf/locale/.

Indeed set_language (https://github.com/django/django/blob/stable/1.11.x/django/views/i18n.py#L50) calls the function check_for_language. check_for_language will check if the language in parameter exists in the gettext catalog. However, check_for_language calls the function all_locale_paths (https://github.com/django/django/blob/stable/1.11.x/django/utils/translation/trans_real.py#L411) which doesn't contains the path of the apps.

I create a language that doesn't exist in the Django default language, I can't switch to this language because it cannot be found, it only exists in the locale directory inside my apps.

Change History (9)

comment:1 Changed 6 months ago by Claude Paroz

Easy pickings: unset
Has patch: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 6 months ago by ChillarAnand

Owner: changed from nobody to ChillarAnand
Status: newassigned

comment:3 Changed 5 months ago by ChillarAnand

Cc: ChillarAnand added
Has patch: set

comment:4 Changed 5 months ago by Claude Paroz

Needs tests: set

comment:5 Changed 5 months ago by ChillarAnand

Needs tests: unset

Thanks Claude Paroz. Added a test case.

comment:8 Changed 3 months ago by Tim Graham

Patch needs improvement: set

Left a comment for improvement about putting the test in a better location.

comment:9 Changed 2 months ago by ChillarAnand

Patch needs improvement: unset

Added test case for check_for_language.

comment:10 Changed 2 months ago by Carlton Gibson

Triage Stage: AcceptedReady for checkin

comment:11 Changed 2 months ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In e8e0cfa:

Fixed #28755 -- Made check_for_language() include apps' locale directories.

Note: See TracTickets for help on using tickets.
Back to Top