Opened 17 years ago

Closed 17 years ago

#2873 closed defect (fixed)

django.conf.urls.registration contains World Online cruft

Reported by: James Bennett Owned by: Adrian Holovaty
Component: Core (Other) Version:
Severity: normal Keywords:
Cc: donspauldingii@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Summary says it all. There are URLs in there which point to ellington.registration which, obviously, isn't part of Django.

Attachments (1)

ellington-cleanup.diff (1.6 KB ) - added by donspauldingii@… 17 years ago.
Removes the registration.py and admin_password_reset.py

Download all attachments as: .zip

Change History (5)

comment:1 by Simon G. <dev@…>, 17 years ago

Triage Stage: UnreviewedAccepted
Version: SVN

comment:2 by jmcameron@…, 17 years ago

This and it isn't quite as simple as it seems because none the registration views that are referred to in the ellington modules are currently in django.* code. For instance, in registration.py:13, '...profile/edit$' refers to ellington.registration.views.profile.edit_profile. But no view with the name 'edit_profile' exists in any of the files in the main trunk (django.*). If suitable registration views/functions are added to the public release of django, then these changes should be trivial. Until then, it might be best to comment out these lines in publically released versions.

by donspauldingii@…, 17 years ago

Attachment: ellington-cleanup.diff added

Removes the registration.py and admin_password_reset.py

comment:3 by donspauldingii@…, 17 years ago

Cc: donspauldingii@… added

These two URLConf files seem to be left over from a more "tightly-coupled" time. Attached diff to remove the ones that didn't appear generic, is a diff necessary for something like this? Are people using the I18N and content-type shortcut urls in this same directory?

comment:4 by Gary Wilson <gary.wilson@…>, 17 years ago

Resolution: fixed
Status: newclosed

This looks like it was fixed in [4632].

Note: See TracTickets for help on using tickets.
Back to Top