Opened 18 years ago
Closed 18 years ago
#2873 closed defect (fixed)
django.conf.urls.registration contains World Online cruft
Reported by: | James Bennett | Owned by: | Adrian Holovaty |
---|---|---|---|
Component: | Core (Other) | Version: | |
Severity: | normal | Keywords: | |
Cc: | donspauldingii@… | Triage Stage: | Accepted |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Summary says it all. There are URLs in there which point to ellington.registration
which, obviously, isn't part of Django.
Attachments (1)
Change History (5)
comment:1 by , 18 years ago
Triage Stage: | Unreviewed → Accepted |
---|---|
Version: | SVN |
comment:2 by , 18 years ago
by , 18 years ago
Attachment: | ellington-cleanup.diff added |
---|
Removes the registration.py and admin_password_reset.py
comment:3 by , 18 years ago
Cc: | added |
---|
These two URLConf files seem to be left over from a more "tightly-coupled" time. Attached diff to remove the ones that didn't appear generic, is a diff necessary for something like this? Are people using the I18N and content-type shortcut urls in this same directory?
comment:4 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
This looks like it was fixed in [4632].
This and it isn't quite as simple as it seems because none the registration views that are referred to in the ellington modules are currently in django.* code. For instance, in registration.py:13, '...profile/edit$' refers to ellington.registration.views.profile.edit_profile. But no view with the name 'edit_profile' exists in any of the files in the main trunk (django.*). If suitable registration views/functions are added to the public release of django, then these changes should be trivial. Until then, it might be best to comment out these lines in publically released versions.