Code

Opened 8 years ago

Closed 7 years ago

#2873 closed defect (fixed)

django.conf.urls.registration contains World Online cruft

Reported by: ubernostrum Owned by: adrian
Component: Core (Other) Version:
Severity: normal Keywords:
Cc: donspauldingii@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Summary says it all. There are URLs in there which point to ellington.registration which, obviously, isn't part of Django.

Attachments (1)

ellington-cleanup.diff (1.6 KB) - added by donspauldingii@… 7 years ago.
Removes the registration.py and admin_password_reset.py

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Triage Stage changed from Unreviewed to Accepted
  • Version SVN deleted

comment:2 Changed 7 years ago by jmcameron@…

This and it isn't quite as simple as it seems because none the registration views that are referred to in the ellington modules are currently in django.* code. For instance, in registration.py:13, '...profile/edit$' refers to ellington.registration.views.profile.edit_profile. But no view with the name 'edit_profile' exists in any of the files in the main trunk (django.*). If suitable registration views/functions are added to the public release of django, then these changes should be trivial. Until then, it might be best to comment out these lines in publically released versions.

Changed 7 years ago by donspauldingii@…

Removes the registration.py and admin_password_reset.py

comment:3 Changed 7 years ago by donspauldingii@…

  • Cc donspauldingii@… added

These two URLConf files seem to be left over from a more "tightly-coupled" time. Attached diff to remove the ones that didn't appear generic, is a diff necessary for something like this? Are people using the I18N and content-type shortcut urls in this same directory?

comment:4 Changed 7 years ago by Gary Wilson <gary.wilson@…>

  • Resolution set to fixed
  • Status changed from new to closed

This looks like it was fixed in [4632].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.