Password reset shouldn't depend on the current password being hashed with a supported hasher

[Josh Harwood]

Currently the built in django password reset system requires that you have an active account and that your password can be compared to by an enabled hasher.

I think that this is in error, as you are about to reset the password to something new (hence resetting it) and the standard process of password resetting requires an email confirmation. I can see no way in which this is able to be abused by a malicious 3rd party. If I'm mistaken here then feel free to correct me.

I propose that the system is changed to just require that the user is active and that their password is not marked disabled as per the UNUSABLE_PASSWORD_PREFIX.

[Tim Graham]

Where's that restriction implemented?

[Josh Harwood]

Replying to Tim Graham:

Where's that restriction implemented?

This line with "has_usable_password": ​https://github.com/django/django/blob/master/django/contrib/auth/forms.py#L264

[Tim Graham]

It looks like this is a regression in aeb1389442d0f9669edf6660b747fd10693b63a7. The change in django/contrib/auth/forms.py line 234 added the undesired check that the password uses a valid hasher.

[Levi Payne]

​PR

[Levi Payne]

Not going to be able to finish this. Just needs unit tests. See pull request for more details.

[Tim Graham]

I think the change to has_usable_password() in 703c266682be39f7153498ad0d8031231f12ee79 was unintentional and that adding a User.has_disabled_password() method as originally proposed here will only add more confusion. I've proposed an ​alternate PR.

[Tim Graham <timograham@…>]

In 43348e4a:

Reverted "[2.0.x] Expanded docs for AbstractBaseUser.has_usable_password()."

This reverts commit c2962d8147380b00bb965c0d42b7e05ca4596868. After discussion
in refs #28718, the decision is to treat the reverted statements as bugs.

[Tim Graham <timograham@…>]

In a4f0e9ae:

Fixed #28718 -- Allowed user to request a password reset if their password doesn't use an enabled hasher.

Regression in aeb1389442d0f9669edf6660b747fd10693b63a7.
Reverted changes to is_password_usable() from
703c266682be39f7153498ad0d8031231f12ee79 and documentation changes from
92f48680dbd2e02f2b33f6ad0e35b7d337889fb2.