Opened 5 months ago

Closed 5 hours ago

#28635 closed Bug (fixed)

admin's preserved filters don't work if the URL has non-ASCII characters in it

Reported by: Wenli Tsai Owned by: nobody
Component: contrib.admin Version: 1.11
Severity: Normal Keywords: add_preserved_filters
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Wenli Tsai)

The preserved_filters won't be correctly recovered when url contains unicode prefix.

When save the change form and return to the changelist,
the changelist url should be /admin/myApp/台灣Model/?cityID=a.

But we got /admin/myApp/台灣Model/?_changelist_filters=cityID%3Da,
and 302 redirected to /admin/myApp/台灣Model/?e=1.

Change History (7)

comment:1 Changed 5 months ago by Wenli Tsai

Description: modified (diff)

comment:2 Changed 5 months ago by Wenli Tsai

Summary: Non-ASCII url prefixPreserved filters with non-ASCII url prefix

comment:3 Changed 5 months ago by Wenli Tsai

Summary: Preserved filters with non-ASCII url prefixPreserved filters with unicode url prefix

comment:4 Changed 5 months ago by Wenli Tsai

Description: modified (diff)

comment:5 Changed 5 months ago by Tim Graham

Has patch: set
Summary: Preserved filters with unicode url prefixadmin's preserved filters don't work if the URL has non-ASCII characters in it
Triage Stage: UnreviewedAccepted

comment:6 Changed 2 weeks ago by Carlton Gibson

Triage Stage: AcceptedReady for checkin

PR looks good.

comment:7 Changed 5 hours ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In ba37ee9e:

Fixed #28635 -- Fixed admin's preserved filters if the URL contains non-ASCII characters.

Note: See TracTickets for help on using tickets.
Back to Top