Opened 19 months ago

Closed 6 months ago

Last modified 3 months ago

#28606 closed Cleanup/optimization (fixed)

Deprecate CachedStaticFilesStorage

Reported by: Ed Morley Owned by: nobody
Component: contrib.staticfiles Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

CachedStaticFilesStorage has a number of drawbacks, and the docs in fact already steer people away from using it:
https://docs.djangoproject.com/en/1.11/ref/contrib/staticfiles/#django.contrib.staticfiles.storage.CachedStaticFilesStorage

An additional problem is that HashedFilesMixin has had to make several compromises in order to support CachedStaticFilesStorage which unfortunately also impacts users of the recommended ManifestStaticFilesStorage backend (see #28604). When these compromises were added in #24452, it was suggested that CachedStaticFilesStorage should just be deprecated/removed instead.

It's now too late to mark it as deprecated for Django 2.0, but we can do so for Django 2.1 which would end up with its removal being in Django 3.0 all the same anyway.

I started this mailing list thread about the deprecation:
https://groups.google.com/forum/#!topic/django-developers/fmfQvuHBStk

Change History (6)

comment:1 Changed 19 months ago by Tim Graham

Summary: Mark CachedStaticFilesStorage as deprecated in Django 2.1Deprecate CachedStaticFilesStorage
Triage Stage: UnreviewedAccepted

comment:2 Changed 6 months ago by Tim Graham

Has patch: set

comment:3 Changed 6 months ago by Simon Charette

Triage Stage: AcceptedReady for checkin

comment:4 Changed 6 months ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In f892781b:

Fixed #28606 -- Deprecated CachedStaticFilesStorage.

comment:5 Changed 3 months ago by Tim Graham <timograham@…>

In 6713926e:

Refs #28606 -- Corrected deprecation version for CachedStaticFilesStorage.

comment:6 Changed 3 months ago by Tim Graham <timograham@…>

In a9feec5c:

[2.2.x] Refs #28606 -- Corrected deprecation version for CachedStaticFilesStorage.

Backport of 6713926ebe22172e50f283185f969275c326416d from master

Note: See TracTickets for help on using tickets.
Back to Top