Opened 7 years ago
Last modified 20 months ago
#28592 new Cleanup/optimization
Reorganize CSRF documentation and add to FAQs
Reported by: | Daniele Procida | Owned by: | Samith Karunathilake |
---|---|---|---|
Component: | Documentation | Version: | 1.11 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
The CSRF documentation can be improved.
It currently mixes up topic, reference, and how-to material all in the same document.
The CSRF sections can be expanded to address some common questions about the way Django does this.
Change History (21)
comment:1 by , 7 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:2 by , 7 years ago
Description: | modified (diff) |
---|---|
Patch needs improvement: | set |
Summary: | Security documentation updates → Reorganize CSRF documentation and add to FAQs |
Triage Stage: | Unreviewed → Accepted |
comment:3 by , 4 years ago
Patch needs improvement: | unset |
---|
comment:4 by , 4 years ago
Patch needs improvement: | set |
---|
This patch is not mergeable anymore. It has a lot of conflicts with the current master, it seems that a new PR is needed to move it forward.
comment:5 by , 4 years ago
Easy pickings: | set |
---|
comment:6 by , 4 years ago
Owner: | removed |
---|---|
Status: | assigned → new |
comment:7 by , 4 years ago
David, I have doubts that refactoring a security-related docs is "easy picking".
comment:8 by , 4 years ago
Hi Mariusz -- you could well be right here, this is certainly not a ticket suited for a beginner.
My thinking was that if a knowledgeable professional comes to look at this, they may find it "easier" as there is prior work here that's already had some reviews. It therefore could "easier" (but by no means easy!) than starting from a scratch.
comment:9 by , 3 years ago
Owner: | set to |
---|---|
Patch needs improvement: | unset |
Status: | new → assigned |
New PR. Tomas, could you add Daniele as a co-author?
comment:10 by , 3 years ago
Patch needs improvement: | set |
---|
comment:15 by , 22 months ago
Owner: | removed |
---|---|
Status: | assigned → new |
follow-up: 17 comment:16 by , 21 months ago
May I know if this ticket is closed? If not closed can I work on it?
follow-up: 18 comment:17 by , 21 months ago
Replying to madhuri2:
May I know if this ticket is closed?
No.
If not closed can I work on it?
Sure, feel-free.
comment:19 by , 21 months ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:20 by , 20 months ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
CSRF Documentation was updated and the results were successfully merged as of March 2022, as seen in this thread: https://github.com/django/django/pull/14956
comment:21 by , 20 months ago
Easy pickings: | unset |
---|---|
Resolution: | fixed |
Status: | closed → new |
Not all the work is merged, that's why the ticket was left open.
Hello from the future, Daniele. Found this PR while surfing GitHub. I'm resetting the review flag since it looks like you're caught up on feedback.
PR