When saving in admin, readonly fields are potentially overwritten

[Fingal Plumpton]

On the admin page for a model, if a field is in readonly_fields or has editable=False, then saving that model from the admin will create an SQL query that sets the readonly field to it's value at the time the save button was clicked. This field might have been changed (e.g. by a command or some other process) during the time that the model is being saved, and with current behaviour it would then be overwritten to it's old value.

Correct behaviour would be to not set the readonly/uneditable field at all in the SQL query.

The exception to this is a DateTimeField with auto_now or auto_now_add, which have editable=False but should be updated when the SQL query is made.

[Fingal Plumpton]

​PR

[Tim Graham]

Recently, someone raised ​a similar issue for model forms. I think the problem should be solved at that level first. Perhaps that'll help simplify the code at the admin level -- the current code looks too complicated.

[Alexander Lazarević]

So for what it's worth, this seems to be still the case in 5.1.dev20240112204018:

UPDATE "empty_somemodel"
   SET "name" = '''wowzer'',
       "description" = '''''',
       "choices" = '''''',
       "random_tag" = '''9436''',
       "date" = '''2024-01-01''',
       "time" = '''11:18:48''',
       "boolean" = 'False',
       "decimal" = '''0.01''',
       "floating" = '1.0',
       "json" = '''{}'''
 WHERE "empty_somemodel"."id" = '1'

class SomeModel(models.Model):
...
    random_tag = models.CharField(null=False, max_length=32, default=random_text, editable=False)
...